SONARPY-3982 Add Security/DBD/Architecture rules to AI quality profile (#1015)

GitOrigin-RevId: ac8c6fff6a312746aa42beb649ed69d01b6ba762

Author: guillaume-dequenne

python-checks/src/main/java/org/sonar/python/checks/OpenSourceCheckList.java

@@ -111,7 +111,7 @@ public class OpenSourceCheckList {
 
   public static final String RESOURCE_FOLDER = "org/sonar/l10n/py/rules/python";
   public static final String SONAR_WAY_PROFILE_LOCATION = RESOURCE_FOLDER + "/Sonar_way_profile.json";
-  public static final String AI_QUALITY_PROFILE_LOCATION = RESOURCE_FOLDER + "/AI_quality_profile.json";
+  public static final String AI_QUALITY_PROFILE_LOCATION = RESOURCE_FOLDER + "/Sonar_agentic_AI_profile.json";
 
   public Stream<Class<?>> getChecks() {
     return Stream.of(

…/py/rules/python/AI_quality_profile.json …les/python/Sonar_agentic_AI_profile.jsonpython-checks/src/main/resources/org/sonar/l10n/py/rules/python/AI_quality_profile.json renamed to python-checks/src/main/resources/org/sonar/l10n/py/rules/python/Sonar_agentic_AI_profile.json python-checks/src/main/resources/org/sonar/l10n/py/rules/python/AI_quality_profile.json renamed to python-checks/src/main/resources/org/sonar/l10n/py/rules/python/Sonar_agentic_AI_profile.json

@@ -1,5 +1,5 @@
 {
-  "name": "AI quality profile",
+  "name": "Sonar agentic AI",
   "ruleKeys": [
     "S100",
     "S101",

python-commons/src/main/java/org/sonar/plugins/python/AIQualityProfile.java

@@ -23,7 +23,7 @@
 
 public class AIQualityProfile implements BuiltInQualityProfilesDefinition {
 
-  static final String PROFILE_NAME = "AI quality profile";
+  static final String PROFILE_NAME = "Sonar agentic AI";
 
   private final RepositoryInfoProvider[] editionMetadataProviders;
 
@@ -39,6 +39,12 @@ public void define(Context context) {
       registerRulesForEdition(repositoryInfoProvider, profile);
     }
 
+    PythonProfile.getSecurityRuleKeys()
+      .forEach(key -> profile.activateRule(key.repository(), key.rule()));
+    PythonProfile.getDataflowBugDetectionRuleKeys()
+      .forEach(key -> profile.activateRule(key.repository(), key.rule()));
+    PythonProfile.getArchitectureRuleKeys()
+      .forEach(key -> profile.activateRule(key.repository(), key.rule()));
     profile.done();
   }
 

python-commons/src/main/java/org/sonar/plugins/python/IPynbAIQualityProfile.java

@@ -23,7 +23,7 @@
 
 public class IPynbAIQualityProfile implements BuiltInQualityProfilesDefinition {
 
-  static final String PROFILE_NAME = "AI quality profile";
+  static final String PROFILE_NAME = "Sonar agentic AI";
 
   private final RepositoryInfoProvider[] editionMetadataProviders;
 

python-commons/src/test/java/org/sonar/plugins/python/AIQualityProfileTest.java

@@ -16,6 +16,9 @@
  */
 package org.sonar.plugins.python;
 
+import com.sonar.plugins.security.api.PythonRules;
+import com.sonarsource.plugins.architecturepythonfrontend.api.ArchitecturePythonRules;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.sonar.api.server.profile.BuiltInQualityProfilesDefinition;
 import org.sonar.api.server.profile.BuiltInQualityProfilesDefinition.BuiltInActiveRule;
@@ -26,10 +29,20 @@
 
 class AIQualityProfileTest {
 
+  @BeforeEach
+  void setUp() {
+    PythonRules.throwOnCall = false;
+    PythonRules.getRuleKeys().clear();
+    com.sonarsource.plugins.dbd.api.PythonRules.throwOnCall = false;
+    com.sonarsource.plugins.dbd.api.PythonRules.getDataflowBugDetectionRuleKeys().clear();
+    ArchitecturePythonRules.throwOnCall = false;
+    ArchitecturePythonRules.getRuleKeys().clear();
+  }
+
   public BuiltInQualityProfilesDefinition.BuiltInQualityProfile getProfile() {
     BuiltInQualityProfilesDefinition.Context context = new BuiltInQualityProfilesDefinition.Context();
     new AIQualityProfile(new RepositoryInfoProvider[]{new OpenSourceRepositoryInfoProvider()}).define(context);
-    return context.profile("py", "AI quality profile");
+    return context.profile("py", "Sonar agentic AI");
   }
 
   @Test
@@ -39,4 +52,40 @@ void profile() {
     assertThat(profile.rules()).hasSizeGreaterThan(25);
     assertThat(profile.rules()).extracting(BuiltInActiveRule::ruleKey).contains("S100");
   }
+
+  @Test
+  void should_contain_security_rules_when_available() {
+    PythonRules.getRuleKeys().add("S3649");
+    try {
+      BuiltInQualityProfilesDefinition.BuiltInQualityProfile profile = getProfile();
+      assertThat(profile.rules()).extracting("repoKey").contains("pythonsecurity");
+      assertThat(profile.rules()).extracting(BuiltInActiveRule::ruleKey).contains("S3649");
+    } finally {
+      PythonRules.getRuleKeys().clear();
+    }
+  }
+
+  @Test
+  void should_contain_dataflow_bug_detection_rules_when_available() {
+    com.sonarsource.plugins.dbd.api.PythonRules.getDataflowBugDetectionRuleKeys().add("S2259");
+    try {
+      BuiltInQualityProfilesDefinition.BuiltInQualityProfile profile = getProfile();
+      assertThat(profile.rules()).extracting("repoKey").contains("dbd-repo-key");
+      assertThat(profile.rules()).extracting(BuiltInActiveRule::ruleKey).contains("S2259");
+    } finally {
+      com.sonarsource.plugins.dbd.api.PythonRules.getDataflowBugDetectionRuleKeys().clear();
+    }
+  }
+
+  @Test
+  void should_contain_architecture_rules_when_available() {
+    ArchitecturePythonRules.getRuleKeys().add("S7134");
+    try {
+      BuiltInQualityProfilesDefinition.BuiltInQualityProfile profile = getProfile();
+      assertThat(profile.rules()).extracting("repoKey").contains("pythonarchitecture");
+      assertThat(profile.rules()).extracting(BuiltInActiveRule::ruleKey).contains("S7134");
+    } finally {
+      ArchitecturePythonRules.getRuleKeys().clear();
+    }
+  }
 }

python-commons/src/test/java/org/sonar/plugins/python/IPynbAIQualityProfileTest.java

@@ -29,7 +29,7 @@ class IPynbAIQualityProfileTest {
   public BuiltInQualityProfilesDefinition.BuiltInQualityProfile getProfile() {
     BuiltInQualityProfilesDefinition.Context context = new BuiltInQualityProfilesDefinition.Context();
     new IPynbAIQualityProfile(new RepositoryInfoProvider[]{new OpenSourceRepositoryInfoProvider()}).define(context);
-    return context.profile("ipynb", "AI quality profile");
+    return context.profile("ipynb", "Sonar agentic AI");
   }
 
   @Test