SONARPY-3987 Fix S117 false positive for UPPERCASE params in marimo cell functions (#1030)

Co-authored-by: Vibe Bot <vibe-bot@sonarsource.com>
GitOrigin-RevId: a779359a4b9af41c23550f4d479b3b94070fb65e

Author: 2 people

python-checks/src/main/java/org/sonar/python/checks/LocalVariableAndParameterNameConventionCheck.java

@@ -40,6 +40,7 @@
 import org.sonar.plugins.python.api.tree.SubscriptionExpression;
 import org.sonar.plugins.python.api.tree.Tree;
 import org.sonar.plugins.python.api.types.v2.PythonType;
+import org.sonar.python.checks.utils.MarimoUtils;
 import org.sonar.python.semantic.SymbolUtils;
 import org.sonar.python.tree.TreeUtils;
 import org.sonar.python.types.v2.TypeCheckBuilder;
@@ -170,7 +171,7 @@ private void raiseIssueForNameAndUsage(SubscriptionContext ctx, String name, Usa
       if (name.length() <= 1) {
         return;
       }
-    } else if (kind == UsageV2.Kind.PARAMETER && isParameterNameFromOverriddenMethod(usage, name)) {
+    } else if (kind == UsageV2.Kind.PARAMETER && (isParameterNameFromOverriddenMethod(usage, name) || MarimoUtils.isTreeInMarimoDecoratedFunction(usage.tree(), ctx))) {
       return;
     }
     ctx.addIssue(usage.tree(), String.format(MESSAGE, type, name, format));

python-checks/src/test/resources/checks/localVariableAndParameterNameIncompatibility.py

@@ -145,3 +145,31 @@ def execute(self):
 class DerivedLongerSignature(BaseShortSignature):
     def execute(self, ExtraParam):  # Noncompliant
         pass
+
+
+import marimo
+
+app = marimo.App()
+
+
+@app.cell
+def _():
+    TSHIRT_ORDER = ["XS", "S", "M", "L", "XL", "XXL"]
+    return TSHIRT_ORDER,
+
+
+@app.cell
+def _(TSHIRT_ORDER):
+    filtered = [size for size in TSHIRT_ORDER if size != "XXL"]
+    return filtered,
+
+
+@app.cell(hide_code=True)
+def _(API_KEY, DB_CONFIG):
+    connection_string = f"host={DB_CONFIG['host']}?key={API_KEY}"
+    return connection_string,
+
+
+@app.function
+def helper(INPUT_DATA):
+    return INPUT_DATA