JS-1523 Handle invalid parsing pointers from stylelint/postcss (#6714)

Author: vdiez

packages/analysis/src/css/analysis/analyzer.ts

@@ -64,7 +64,10 @@ export async function analyzeCSS(
   if (isTestFile && !includeMetrics) {
     return { issues: [] };
   }
-  const sanitizedCode = fileContent.replaceAll(/[\u2000-\u200F]/g, ' ');
+  const sanitizedCode = fileContent
+    .replaceAll(/[\u2000-\u200F]/g, ' ')
+    // PostCSS tracks lines by splitting on '\n'; normalize CR-only files to keep locations stable.
+    .replaceAll(/\r(?!\n)/g, '\n');
 
   // TEST files keep highlighting (parity with old CssMetricSensor), but issues remain suppressed.
   const lintResult = await linter.lint(filePath, sanitizedCode, fileType);

packages/analysis/tests/analyzeProject-sonarqube.test.ts

@@ -23,6 +23,7 @@ import { analyzeProject, cancelAnalysis } from '../src/analyzeProject.js';
 import { sourceFileStore, tsConfigStore } from '../src/file-stores/index.js';
 import { ErrorCode } from '../src/contracts/error.js';
 import ts from 'typescript';
+import { valid } from 'semver';
 import type { RuleConfig } from '../src/jsts/linter/config/rule-config.js';
 import type { RuleConfig as CssRuleConfig } from '../src/css/linter/config.js';
 import { getProgramCacheManager } from '../src/jsts/program/cache/programCache.js';
@@ -174,8 +175,11 @@ describe('SonarQube project analysis', () => {
     expect('issues' in backendResult! && backendResult!.issues.length).toBeGreaterThan(0);
 
     expect(result.meta.telemetry).toBeDefined();
+    expect(result.meta.telemetry?.typescriptVersions.length).toBeGreaterThan(0);
+    for (const version of result.meta.telemetry!.typescriptVersions) {
+      expect(valid(version)).toBeTruthy();
+    }
     expect(result.meta.telemetry).toMatchObject({
-      typescriptVersions: ['5.7.2', '7.0.0-dev.20260316.1'],
       typescriptNativePreview: true,
       ecmaScriptVersions: ['ES2020', 'ES2022'],
       esmFileCount: 0,

packages/analysis/tests/css/analysis/analyzer.test.ts

@@ -143,6 +143,16 @@ describe('analyzeCSS', () => {
       data: { line: 2, column: 2 },
     });
   });
+
+  it('should normalize CR-only line endings before parsing embedded CSS', async () => {
+    await expect(
+      analyzeCSS(await input('/some/fake/path.html', '<style>a { color: red; }\r\\n</style>')),
+    ).rejects.toMatchObject({
+      code: ErrorCode.Parsing,
+      message: expect.stringContaining('Unknown word'),
+      data: { line: 2, column: 0 },
+    });
+  });
 });
 
 describe('should emit correctly located issues regardless of invisible characters', () => {

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/AnalysisProcessor.java

@@ -168,13 +168,21 @@ private void processParsingError(JsTsContext<?> context, ParsingError parsingErr
       newIssue.forRule(parsingErrorRuleKey).at(primaryLocation).save();
     }
 
-    context
-      .getSensorContext()
-      .newAnalysisError()
-      .onFile(file)
-      .at(file.newPointer(line != null ? line : 1, toParsingErrorColumn(line, column)))
-      .message(message)
-      .save();
+    var newAnalysisError = context.getSensorContext().newAnalysisError().onFile(file);
+    try {
+      newAnalysisError.at(
+        file.newPointer(line != null ? line : 1, toParsingErrorColumn(line, column))
+      );
+    } catch (RuntimeException e) {
+      LOG.warn(
+        "Failed to create parsing error pointer in {} at line {}, column {}. Falling back to file start.",
+        file.uri(),
+        line,
+        column
+      );
+      newAnalysisError.at(file.newPointer(1, 0));
+    }
+    newAnalysisError.message(message).save();
   }
 
   @Nullable

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/AnalysisProcessorTest.java

@@ -39,6 +39,8 @@
 import org.sonar.plugins.javascript.bridge.BridgeServer.Issue;
 import org.sonar.plugins.javascript.bridge.BridgeServer.Location;
 import org.sonar.plugins.javascript.bridge.BridgeServer.Metrics;
+import org.sonar.plugins.javascript.bridge.BridgeServer.ParsingError;
+import org.sonar.plugins.javascript.bridge.BridgeServer.ParsingErrorCode;
 
 class AnalysisProcessorTest {
 
@@ -197,4 +199,45 @@ void should_not_fail_when_invalid_issue() {
     processor.processResponse(context, mock(JsTsChecks.class), file, response);
     assertThat(logTester.logs()).contains("Failed to save issue in " + file.uri() + " at line 2");
   }
+
+  @Test
+  void should_not_fail_when_invalid_parsing_error_pointer() {
+    var fileLinesContextFactory = mock(FileLinesContextFactory.class);
+    when(fileLinesContextFactory.createFor(any())).thenReturn(mock(FileLinesContext.class));
+    var processor = new AnalysisProcessor(
+      mock(NoSonarFilter.class),
+      fileLinesContextFactory,
+      mock(CssRules.class)
+    );
+    var context = new JsTsContext<SensorContextTester>(SensorContextTester.create(baseDir));
+    var file = TestInputFileBuilder.create("moduleKey", "file.js")
+      .setContents("x")
+      .setLanguage("js")
+      .build();
+
+    var parsingError = new ParsingError(
+      "Parse error message",
+      1,
+      2,
+      ParsingErrorCode.PARSING,
+      "js"
+    );
+    var response = new AnalysisResponse(
+      List.of(parsingError),
+      List.of(),
+      List.of(),
+      List.of(),
+      new Metrics(),
+      List.of(),
+      null
+    );
+
+    processor.processResponse(context, mock(JsTsChecks.class), file, response);
+    assertThat(context.getSensorContext().allAnalysisErrors()).hasSize(1);
+    assertThat(logTester.logs()).contains(
+      "Failed to create parsing error pointer in " +
+        file.uri() +
+        " at line 1, column 2. Falling back to file start."
+    );
+  }
 }