JS-551 - The import of the ESLint issues is done during the execution… (#5097)

Co-authored-by: Eric Morand <eroc.morand@sonarsource.com>

Author: ericmorand-sonarsource

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/AbstractBridgeSensor.java

@@ -20,6 +20,7 @@
 
 import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.function.Predicate;
@@ -35,8 +36,8 @@
 import org.sonar.plugins.javascript.bridge.BridgeServer;
 import org.sonar.plugins.javascript.bridge.BridgeServerConfig;
 import org.sonar.plugins.javascript.bridge.ServerAlreadyFailedException;
-import org.sonar.plugins.javascript.external.EslintReportImporter;
 import org.sonar.plugins.javascript.external.ExternalIssueRepository;
+import org.sonar.plugins.javascript.external.Issue;
 import org.sonar.plugins.javascript.nodejs.NodeCommandException;
 import org.sonar.plugins.javascript.utils.Exclusions;
 
@@ -67,8 +68,7 @@ public void execute(SensorContext context) {
     environments = Arrays.asList(context.config().getStringArray(JavaScriptPlugin.ENVIRONMENTS));
     globals = Arrays.asList(context.config().getStringArray(JavaScriptPlugin.GLOBALS));
 
-    var eslintReportImporter = new EslintReportImporter();
-    var esLintIssues = eslintReportImporter.execute(context);
+    var esLintIssues = this.getESLintIssues(context);
 
     try {
       List<InputFile> inputFiles = getInputFiles();
@@ -142,4 +142,8 @@ protected abstract List<BridgeServer.Issue> analyzeFiles(List<InputFile> inputFi
     throws IOException;
 
   protected abstract List<InputFile> getInputFiles();
+
+  protected List<Issue> getESLintIssues(SensorContext context) {
+    return new ArrayList<>();
+  }
 }

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/analysis/JsTsSensor.java

@@ -23,12 +23,15 @@
 import org.sonar.api.batch.fs.FilePredicate;
 import org.sonar.api.batch.fs.FileSystem;
 import org.sonar.api.batch.fs.InputFile;
+import org.sonar.api.batch.sensor.SensorContext;
 import org.sonar.api.batch.sensor.SensorDescriptor;
 import org.sonar.plugins.javascript.JavaScriptFilePredicate;
 import org.sonar.plugins.javascript.JavaScriptLanguage;
 import org.sonar.plugins.javascript.TypeScriptLanguage;
 import org.sonar.plugins.javascript.bridge.AnalysisMode;
 import org.sonar.plugins.javascript.bridge.BridgeServer;
+import org.sonar.plugins.javascript.external.EslintReportImporter;
+import org.sonar.plugins.javascript.external.Issue;
 
 @DependedUpon("js-analysis")
 public class JsTsSensor extends AbstractBridgeSensor {
@@ -84,4 +87,11 @@ protected List<BridgeServer.Issue> analyzeFiles(List<InputFile> inputFiles) thro
 
     return issues;
   }
+
+  @Override
+  protected List<Issue> getESLintIssues(SensorContext context) {
+    var importer = new EslintReportImporter();
+
+    return importer.execute(context);
+  }
 }

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/analysis/JsTsSensorTest.java

@@ -193,6 +193,12 @@ void should_have_descriptor() throws Exception {
     assertThat(descriptor.languages()).containsOnly("js", "ts");
   }
 
+  /**
+   * todo
+   *
+   * this test should belong to the test suite of the component that actually does the deduplication - namely `AbstractBridgeSensor`;
+   * but there is no test suite for this component.
+   */
   @Test
   void should_de_duplicate_issues() throws Exception {
     JsTsSensor sensor = createSensor();