JS-513 Fix ruling tests

vdiez · kebetsi · commit bda23d1bb583 · 2025-01-13T16:05:47.000+01:00
diff --git a/its/ruling/src/test/expected/jsts/Ghost/javascript-S3798.json b/its/ruling/src/test/expected/jsts/Ghost/javascript-S3798.json
@@ -665,9 +665,6 @@
 "Ghost:core/server/helpers/meta_title.js": [
 11
 ],
-"Ghost:core/server/helpers/navigation.js": [
-11
-],
 "Ghost:core/server/helpers/page_url.js": [
 15,
 16
diff --git a/its/ruling/src/test/expected/jsts/ace/javascript-S131.json b/its/ruling/src/test/expected/jsts/ace/javascript-S131.json
@@ -77,7 +77,6 @@
 103
 ],
 "ace:src/mode/behaviour.js": [
-10,
 10
 ],
 "ace:src/mode/folding/ruby.js": [
diff --git a/its/ruling/src/test/expected/jsts/ace/javascript-S3798.json b/its/ruling/src/test/expected/jsts/ace/javascript-S3798.json
@@ -113,7 +113,6 @@
 53,
 57,
 83,
-92,
 99,
 118,
 140,
diff --git a/its/ruling/src/test/expected/jsts/ant-design/javascript-S3827.json b/its/ruling/src/test/expected/jsts/ant-design/javascript-S3827.json
@@ -1,19 +1,4 @@
 {
-"ant-design:components/menu/__tests__/index.test.js": [
-20
-],
-"ant-design:components/message/__tests__/index.test.js": [
-7
-],
-"ant-design:components/modal/__tests__/confirm.test.js": [
-13
-],
-"ant-design:components/notification/__tests__/index.test.js": [
-8
-],
-"ant-design:components/upload/__tests__/upload.test.js": [
-15
-],
 "ant-design:scripts/batch/convert-demo.js": [
 36
 ],
diff --git a/its/ruling/src/test/expected/jsts/courselit/typescript-S6544.json b/its/ruling/src/test/expected/jsts/courselit/typescript-S6544.json
@@ -0,0 +1,6 @@
+{
+"courselit:apps/web/payments/stripe-payment.ts": [
+23,
+42
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/desktop/typescript-S6544.json b/its/ruling/src/test/expected/jsts/desktop/typescript-S6544.json
@@ -10,6 +10,12 @@
 "desktop:app/src/lib/git/spawn.ts": [
 63
 ],
+"desktop:app/src/lib/stats/stats-store.ts": [
+1090,
+1117,
+1162,
+1169
+],
 "desktop:app/src/lib/stores/app-store.ts": [
 6525
 ],
diff --git a/its/ruling/src/test/expected/jsts/eigen/typescript-S4140.json b/its/ruling/src/test/expected/jsts/eigen/typescript-S4140.json
@@ -1,5 +1,5 @@
 {
 "eigen:src/app/Scenes/Feature/Feature.tests.tsx": [
-65
+86
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/eigen/typescript-S6440.json b/its/ruling/src/test/expected/jsts/eigen/typescript-S6440.json
@@ -33,7 +33,11 @@
 ],
 "eigen:src/app/Components/FancyModal/FancyModalContext.tsx": [
 77,
-86
+86,
+124,
+125,
+127,
+129
 ],
 "eigen:src/app/Components/LoadFailureView.tsx": [
 36
@@ -111,6 +115,9 @@
 "eigen:src/app/Scenes/Sale/Components/SaleHeader.tsx": [
 127
 ],
+"eigen:src/app/Scenes/Search/components/AutosuggestSearchResult.tests.tsx": [
+28
+],
 "eigen:src/app/Scenes/Search/components/SearchInput.tsx": [
 28
 ],
@@ -153,5 +160,8 @@
 ],
 "eigen:src/palette/elements/Tabs/NavigationalTabs.tsx": [
 23
+],
+"eigen:src/palette/elements/Tabs/TabBarContainer.tsx": [
+94
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/es5-shim/javascript-S6551.json b/its/ruling/src/test/expected/jsts/es5-shim/javascript-S6551.json
@@ -1,5 +1,8 @@
 {
 "es5-shim:es5-sham.js": [
 375
+],
+"es5-shim:es5-shim.js": [
+2046
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3827.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3827.json
@@ -15,9 +15,6 @@
 1,
 1
 ],
-"file-for-rules:S3834.js": [
-2
-],
 "file-for-rules:S3854.js": [
 55,
 57,
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3834.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3834.json
@@ -1,5 +1,6 @@
 {
 "file-for-rules:S3834.js": [
-1
+1,
+2
 ]
 }
diff --git a/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3854.json b/its/ruling/src/test/expected/jsts/file-for-rules/javascript-S3854.json
@@ -1,6 +1,5 @@
 {
 "file-for-rules:S3854.js": [
-23,
 72,
 77,
 98,
diff --git a/its/ruling/src/test/expected/jsts/it-tools/typescript-S6551.json b/its/ruling/src/test/expected/jsts/it-tools/typescript-S6551.json
@@ -0,0 +1,11 @@
+{
+"it-tools:src/tools/benchmark-builder/benchmark-builder.models.ts": [
+31
+],
+"it-tools:src/tools/json-to-csv/json-to-csv.service.ts": [
+20
+],
+"it-tools:src/tools/lorem-ipsum-generator/lorem-ipsum-generator.service.ts": [
+183
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/postgraphql/typescript-S6551.json b/its/ruling/src/test/expected/jsts/postgraphql/typescript-S6551.json
@@ -0,0 +1,9 @@
+{
+"postgraphql:src/postgraphql/withPostGraphQLContext.ts": [
+154
+],
+"postgraphql:src/postgres/inventory/collection/PgCollectionKey.ts": [
+194,
+199
+]
+}
diff --git a/its/ruling/src/test/expected/jsts/rxjs/javascript-S3798.json b/its/ruling/src/test/expected/jsts/rxjs/javascript-S3798.json
@@ -16,7 +16,6 @@
 ],
 "rxjs:doc/decision-tree-widget/src/main.js": [
 11,
-36,
 70,
 86,
 97,
diff --git a/its/sources/jsts/custom/S3854.js b/its/sources/jsts/custom/S3854.js
@@ -20,8 +20,8 @@ var B1b = class extends A1 {
 
 class A2 {
   constructor() {
-    super();                 // Noncompliant {{super() can only be invoked in a derived class constructor.}}
-//  ^^^^^
+    super();                 // This is a syntax error
+
     this.f = function() {
       super();               // FN
     }
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/jsts/src/rules/S6544/cb.test.ts b/packages/jsts/src/rules/S6544/cb.test.ts
diff --git a/packages/jsts/src/rules/S6544/fixtures/voidReturnProperty/cb.fixture.ts b/packages/jsts/src/rules/S6544/fixtures/voidReturnProperty/cb.fixture.ts
diff --git a/packages/jsts/src/rules/S6544/rule.ts b/packages/jsts/src/rules/S6544/rule.ts
diff --git a/packages/jsts/src/rules/S6571/cb.fixture.ts b/packages/jsts/src/rules/S6571/cb.fixture.ts
diff --git a/packages/jsts/src/rules/S6571/decorator.ts b/packages/jsts/src/rules/S6571/decorator.ts
diff --git a/packages/jsts/src/rules/S6647/fixtures/problemCode.js b/packages/jsts/src/rules/S6647/fixtures/problemCode.js
diff --git a/packages/jsts/src/rules/S6647/unit.test.ts b/packages/jsts/src/rules/S6647/unit.test.ts

Original file line number	Diff line number	Diff line change
`@@ -665,9 +665,6 @@`
`665`	`665`	`"Ghost:core/server/helpers/meta_title.js": [`
`666`	`666`	`11`
`667`	`667`	`],`
`668`		`-"Ghost:core/server/helpers/navigation.js": [`
`669`		`-11`
`670`		`-],`
`671`	`668`	`"Ghost:core/server/helpers/page_url.js": [`
`672`	`669`	`15,`
`673`	`670`	`16`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,6 @@`
`77`	`77`	`103`
`78`	`78`	`],`
`79`	`79`	`"ace:src/mode/behaviour.js": [`
`80`		`-10,`
`81`	`80`	`10`
`82`	`81`	`],`
`83`	`82`	`"ace:src/mode/folding/ruby.js": [`
-Original file line number
+Diff line change
 ,
 ,
 ,
 -92,
 ,
 ,
 ,
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,12 @@`
`10`	`10`	`"desktop:app/src/lib/git/spawn.ts": [`
`11`	`11`	`63`
`12`	`12`	`],`
	`13`	`+"desktop:app/src/lib/stats/stats-store.ts": [`
	`14`	`+1090,`
	`15`	`+1117,`
	`16`	`+1162,`
	`17`	`+1169`
	`18`	`+],`
`13`	`19`	`"desktop:app/src/lib/stores/app-store.ts": [`
`14`	`20`	`6525`
`15`	`21`	`],`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"eigen:src/app/Scenes/Feature/Feature.tests.tsx": [`
`3`		`-65`
	`3`	`+86`
`4`	`4`	`]`
`5`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,11 @@`
`33`	`33`	`],`
`34`	`34`	`"eigen:src/app/Components/FancyModal/FancyModalContext.tsx": [`
`35`	`35`	`77,`
`36`		`-86`
	`36`	`+86,`
	`37`	`+124,`
	`38`	`+125,`
	`39`	`+127,`
	`40`	`+129`
`37`	`41`	`],`
`38`	`42`	`"eigen:src/app/Components/LoadFailureView.tsx": [`
`39`	`43`	`36`
`@@ -111,6 +115,9 @@`
`111`	`115`	`"eigen:src/app/Scenes/Sale/Components/SaleHeader.tsx": [`
`112`	`116`	`127`
`113`	`117`	`],`
	`118`	`+"eigen:src/app/Scenes/Search/components/AutosuggestSearchResult.tests.tsx": [`
	`119`	`+28`
	`120`	`+],`
`114`	`121`	`"eigen:src/app/Scenes/Search/components/SearchInput.tsx": [`
`115`	`122`	`28`
`116`	`123`	`],`
`@@ -153,5 +160,8 @@`
`153`	`160`	`],`
`154`	`161`	`"eigen:src/palette/elements/Tabs/NavigationalTabs.tsx": [`
`155`	`162`	`23`
	`163`	`+],`
	`164`	`+"eigen:src/palette/elements/Tabs/TabBarContainer.tsx": [`
	`165`	`+94`
`156`	`166`	`]`
`157`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,8 @@`
`1`	`1`	`{`
`2`	`2`	`"es5-shim:es5-sham.js": [`
`3`	`3`	`375`
	`4`	`+],`
	`5`	`+"es5-shim:es5-shim.js": [`
	`6`	`+2046`
`4`	`7`	`]`
`5`	`8`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,6 @@`
`15`	`15`	`1,`
`16`	`16`	`1`
`17`	`17`	`],`
`18`		`-"file-for-rules:S3834.js": [`
`19`		`-2`
`20`		`-],`
`21`	`18`	`"file-for-rules:S3854.js": [`
`22`	`19`	`55,`
`23`	`20`	`57,`