ESLINTJS-60 Remove dependency on Babel for rule S125 (#5074)

Author: vdiez

generate-eslint-package-json.mjs

@@ -19,12 +19,6 @@ import { dirname, join } from 'path';
 import { fileURLToPath } from 'node:url';
 
 const eslintPluginDependencies = [
-  '@babel/core',
-  '@babel/eslint-parser',
-  '@babel/plugin-proposal-decorators',
-  '@babel/preset-env',
-  '@babel/preset-flow',
-  '@babel/preset-react',
   '@eslint-community/regexpp',
   'builtin-modules',
   'bytes',

its/ruling/src/test/expected/jsts/TypeScript/typescript-S125.json

@@ -13,23 +13,35 @@
 "TypeScript:src/compiler/checker.ts": [
 1063,
 2774,
+21568,
 22486
 ],
 "TypeScript:src/compiler/factory.ts": [
+4151,
+4170,
 4208,
 4215,
 4229,
 4236
 ],
+"TypeScript:src/compiler/parser.ts": [
+4135,
+4146
+],
 "TypeScript:src/compiler/transformers/es2015.ts": [
+664,
 716,
 735,
 1356,
 1376
 ],
+"TypeScript:src/compiler/transformers/generators.ts": [
+1682
+],
 "TypeScript:src/compiler/transformers/module/module.ts": [
 507,
 513,
+523,
 561,
 694,
 730

its/ruling/src/test/expected/jsts/ace/javascript-S125.json

@@ -34,6 +34,7 @@
 2728,
 2787,
 2840,
+3108,
 7409,
 7817
 ],

its/ruling/src/test/expected/jsts/console/typescript-S125.json

@@ -2,15 +2,15 @@
 "console:src/actions/databrowser/data.ts": [
 159
 ],
-"console:src/components/CallToAction.tsx.ts": [
-1
-],
 "console:src/components/Modal.tsx": [
 18
 ],
 "console:src/mutations/SetPlanMutation.ts": [
 41
 ],
+"console:src/views/FunctionsView/FunctionLogs/Log.tsx": [
+6
+],
 "console:src/views/PermissionsView/PermissionsList/ModelPermissions/ModelPermissionList.tsx": [
 13
 ],
@@ -35,5 +35,8 @@
 ],
 "console:src/views/models/FieldPopup/Constraints.tsx": [
 209
+],
+"console:src/views/playground/PlaygroundView/PlaygroundView.tsx": [
+127
 ]
 }

its/ruling/src/test/expected/jsts/eigen/typescript-S125.json

@@ -0,0 +1,5 @@
+{
+"eigen:src/app/Scenes/MyCollection/Screens/ArtworkForm/Form/useArtworkForm.tests.tsx": [
+5
+]
+}

its/ruling/src/test/expected/jsts/paper.js/javascript-S125.json

@@ -13,6 +13,10 @@
 "paper.js:src/basic/Matrix.js": [
 709
 ],
+"paper.js:src/canvas/BlendMode.js": [
+121,
+130
+],
 "paper.js:src/path/Curve.js": [
 101
 ],

its/ruling/src/test/expected/jsts/vuetify/typescript-S125.json

@@ -20,6 +20,7 @@
 71,
 78,
 81,
+89,
 96,
 101,
 106,
@@ -43,8 +44,12 @@
 130
 ],
 "vuetify:packages/vuetify/src/components/VOverlay/locationStrategies.ts": [
+120,
 140
 ],
+"vuetify:packages/vuetify/src/composables/__tests__/theme.spec.ts": [
+147
+],
 "vuetify:packages/vuetify/src/composables/touch.ts": [
 26
 ],

packages/jsts/src/rules/S125/rule.ts

@@ -16,18 +16,13 @@
  */
 // https://sonarsource.github.io/rspec/#/rspec/S125/javascript
 
-import { Rule, SourceCode } from 'eslint';
+import { AST, Rule, SourceCode } from 'eslint';
 import estree from 'estree';
 import type { TSESTree } from '@typescript-eslint/utils';
-import babel from '@babel/eslint-parser';
 import { generateMeta } from '../helpers/index.js';
 import { meta } from './meta.js';
 import { CodeRecognizer, JavaScriptFootPrint } from '../helpers/recognizers/index.js';
-
-import babelPresetReact from '@babel/preset-react';
-import babelPresetFlow from '@babel/preset-flow';
-import babelPresetEnv from '@babel/preset-env';
-import babelPluginDecorators from '@babel/plugin-proposal-decorators';
+import path from 'path';
 
 const EXCLUDED_STATEMENTS = ['BreakStatement', 'LabeledStatement', 'ContinueStatement'];
 
@@ -93,7 +88,10 @@ export const rule: Rule.RuleModule = {
         );
         groupedComments.forEach(groupComment => {
           const rawTextTrimmed = groupComment.value.trim();
-          if (rawTextTrimmed !== '}' && containsCode(injectMissingBraces(rawTextTrimmed))) {
+          if (
+            rawTextTrimmed !== '}' &&
+            containsCode(injectMissingBraces(rawTextTrimmed), context)
+          ) {
             context.report({
               messageId: 'commentedCode',
               loc: getCommentLocation(groupComment.nodes),
@@ -143,39 +141,24 @@ function isExclusion(parsedBody: Array<estree.Node>, code: SourceCode) {
   return false;
 }
 
-function containsCode(value: string) {
-  if (!couldBeJsCode(value)) {
+function containsCode(value: string, context: Rule.RuleContext) {
+  if (!couldBeJsCode(value) || !context.languageOptions.parser) {
     return false;
   }
 
   try {
-    const result = babel.parse(value, {
-      filename: 'some/filePath',
-      tokens: true,
-      comment: true,
-      loc: true,
-      range: true,
-      ecmaVersion: 2018,
-      sourceType: 'module',
-      codeFrame: false,
-      ecmaFeatures: {
-        jsx: true,
-        globalReturn: false,
-        legacyDecorators: true,
-      },
-      requireConfigFile: false,
-      babelOptions: {
-        targets: 'defaults',
-        presets: [babelPresetReact, babelPresetFlow, babelPresetEnv],
-        plugins: [[babelPluginDecorators, { version: '2022-03' }]],
-        babelrc: false,
-        configFile: false,
-        parserOpts: {
-          allowReturnOutsideFunction: true,
-        },
-      },
-    });
-    const parseResult = new SourceCode(value, result);
+    const options = {
+      ...context.languageOptions?.parserOptions,
+      filePath: `placeholder${path.extname(context.filename)}`,
+      programs: undefined,
+      project: undefined,
+    };
+    //In case of Vue parser: we will use the JS/TS parser instead of the Vue parser
+    const parser =
+      context.languageOptions?.parserOptions?.parser ?? context.languageOptions?.parser;
+    const result =
+      'parse' in parser ? parser.parse(value, options) : parser.parseForESLint(value, options).ast;
+    const parseResult = new SourceCode(value, result as AST.Program);
     return parseResult.ast.body.length > 0 && !isExclusion(parseResult.ast.body, parseResult);
   } catch (exception) {
     return false;