JS-1136 Fix SonarCloud quality gate code smells (#6227)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: zglicz

.github/workflows/LabelEslintPlugin.yml

@@ -44,10 +44,11 @@ jobs:
       - name: Add eslint-plugin label
         if: steps.extract-jira-key.outputs.has_jira_key == 'true'
         env:
-          JIRA_USER: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_USER }}
-          JIRA_TOKEN: ${{ fromJSON(steps.secrets.outputs.vault).JIRA_TOKEN }}
+          VAULT_OUTPUT: ${{ steps.secrets.outputs.vault }}
           JIRA_KEY: ${{ steps.extract-jira-key.outputs.jira_key }}
         run: |
+          JIRA_USER=$(echo "$VAULT_OUTPUT" | jq -r '.JIRA_USER')
+          JIRA_TOKEN=$(echo "$VAULT_OUTPUT" | jq -r '.JIRA_TOKEN')
           # Use Jira REST API to add label
           curl -s -X PUT \
             -H "Content-Type: application/json" \

packages/jsts/src/rules/S100/rule.ts

@@ -116,10 +116,7 @@ export const rule: Rule.RuleModule = {
         for (let i = ancestors.length - 1; i >= 0; i--) {
           if (functionLike.has(ancestors[i].type)) {
             const enclosingFunction = ancestors[i];
-            if (
-              knowledge?.func === enclosingFunction &&
-              (node.argument as any)?.type?.startsWith('JSX')
-            ) {
+            if (knowledge?.func === enclosingFunction && node.argument?.type.startsWith('JSX')) {
               knowledge.returnsJSX = true;
             }
             return;

packages/jsts/src/rules/S4721/rule.ts

@@ -57,8 +57,8 @@ function checkOSCommand(context: Rule.RuleContext, call: estree.CallExpression)
   const fqnParts = fqn.split('.');
   const module = fqnParts[0];
   // JS-638: Use the last part of the FQN as the method (the actual method being called).
-  const method = fqnParts[fqnParts.length - 1];
-  if (module === CHILD_PROCESS_MODULE && isQuestionable(method, args)) {
+  const method = fqnParts.at(-1);
+  if (method && module === CHILD_PROCESS_MODULE && isQuestionable(method, args)) {
     context.report({
       node: callee,
       messageId: 'safeOSCommand',