Skip to content

Commit 656ccc9

Browse files
authored
JS-558 Add contrib folder name to default exclusions (#5108)
1 parent acfb9c0 commit 656ccc9

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

packages/ruling/tests/tools/testProject.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ const DEFAULT_EXCLUSIONS = [
8484
'**/dist/**',
8585
'**/vendor/**',
8686
'**/external/**',
87+
'**/contrib/**',
8788
].map(pattern => new Minimatch(pattern, { nocase: true, dot: true }));
8889

8990
export function setupBeforeAll(projectFile: string) {

sonar-plugin/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/JavaScriptPlugin.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public class JavaScriptPlugin implements Plugin {
120120
"**/dist/**",
121121
"**/vendor/**",
122122
"**/external/**",
123+
"**/contrib/**",
123124
"**/*.d.ts",
124125
};
125126

sonar-plugin/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/filter/JavaScriptExclusionsFileFilterTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ void should_exclude_node_modules_and_bower_components_by_default() throws Except
6464
assertThat(filter.accept(inputFile("build/some_lib.js"))).isTrue();
6565
assertThat(filter.accept(inputFile("dist/some_lib.js"))).isFalse();
6666
assertThat(filter.accept(inputFile("external/some_lib.js"))).isFalse();
67+
assertThat(filter.accept(inputFile("contrib/some_lib.js"))).isFalse();
6768
assertThat(logTester.logs(Level.DEBUG)).contains(
6869
"File test_node_modules/node_modules/some_lib.js was excluded by sonar.javascript.exclusions or sonar.typescript.exclusions"
6970
);

0 commit comments

Comments
 (0)