JS-1335 feat: add ESLint v10 support; remove code-eval, enforce-trailing-comma, super-invocation from eslint-plugin-sonarjs (#6401)

Co-authored-by: Matt Wilcox <nanpx@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: 4 people

.github/renovate.json

@@ -13,7 +13,8 @@
     "**/fixtures/**",
     "packages/jsts/src/rules/**",
     "its/eslint8-plugin-sonarjs/**",
-    "its/eslint9-plugin-sonarjs/**"
+    "its/eslint9-plugin-sonarjs/**",
+    "its/eslint10-plugin-sonarjs/**"
   ],
   "packageRules": [
     {

.github/workflows/build.yml

@@ -274,6 +274,9 @@ jobs:
     strategy:
       matrix:
         include:
+          - eslint-version: 10
+            node-version: '20.19.0'
+            node-label: 'min supported'
           - eslint-version: 9
             node-version: '18.18.0'
             node-label: 'min supported'

.gitignore

@@ -1,64 +1,65 @@
-# Maven
-target/
-bin/
-.flattened-pom.xml
-
-lib/
-node_modules/
-coverage/
-
-packages/jsts/src/rules/*/generated-meta.ts
-packages/grpc/src/proto/*.js
-packages/grpc/src/proto/*.d.ts
-sonarjs-1.0.0.tgz
-
-# IntelliJ IDEA
-*.iws
-*.iml
-*.ipr
-.idea/
-
-# Eclipse
-.classpath
-.project
-.settings
-
-# Visual Studio
-.vs/
-
-# VS Code
-.vscode/
-
-# ---- Mac OS X
-.DS_Store
-Icon?
-# Thumbnails
-._*
-# Files that might appear on external disk
-.Spotlight-V100
-.Trashes
-
-# ---- Windows
-# Windows image file caches
-Thumbs.db
-# Folder config file
-Desktop.ini
-
-# ---- Sonar
-.sonar
-.scannerwork
-
-# eslint-plugin-sonarjs
-eslint-plugin-sonarjs-*.tgz
-its/eslint8-plugin-sonarjs/package-lock.json
-its/eslint9-plugin-sonarjs/package-lock.json
-
-/resources
-node-info.properties
-
-# coverage
-.nyc_output/
-lcov.info
-
-.claude/*
-!.claude/*.md
+# Maven
+target/
+bin/
+.flattened-pom.xml
+
+lib/
+node_modules/
+coverage/
+
+packages/jsts/src/rules/*/generated-meta.ts
+packages/grpc/src/proto/*.js
+packages/grpc/src/proto/*.d.ts
+sonarjs-1.0.0.tgz
+
+# IntelliJ IDEA
+*.iws
+*.iml
+*.ipr
+.idea/
+
+# Eclipse
+.classpath
+.project
+.settings
+
+# Visual Studio
+.vs/
+
+# VS Code
+.vscode/
+
+# ---- Mac OS X
+.DS_Store
+Icon?
+# Thumbnails
+._*
+# Files that might appear on external disk
+.Spotlight-V100
+.Trashes
+
+# ---- Windows
+# Windows image file caches
+Thumbs.db
+# Folder config file
+Desktop.ini
+
+# ---- Sonar
+.sonar
+.scannerwork
+
+# eslint-plugin-sonarjs
+eslint-plugin-sonarjs-*.tgz
+its/eslint8-plugin-sonarjs/package-lock.json
+its/eslint9-plugin-sonarjs/package-lock.json
+its/eslint10-plugin-sonarjs/package-lock.json
+
+/resources
+node-info.properties
+
+# coverage
+.nyc_output/
+lcov.info
+
+.claude/*
+!.claude/*.md

.pmgrc.toml

@@ -0,0 +1,29 @@
+[data]
+name = "eslint-plugin-sonarjs"
+description = "SonarJS rules for ESLint"
+version = "0.0.0-SNAPSHOT"
+main = "./cjs/plugin.js"
+types = "./types/plugin.d.ts"
+author = "SonarSource"
+license = "LGPL-3.0-only"
+keywords = ["sonarjs", "eslint", "eslintplugin"]
+homepage = "https://github.com/SonarSource/SonarJS/blob/master/packages/jsts/src/rules/README.md"
+
+[data.repository]
+type = "git"
+url = "git+https://github.com/SonarSource/SonarJS.git"
+
+[data.bugs]
+url = "https://community.sonarsource.com/"
+
+[data.peerDependencies]
+eslint = "^8.0.0 || ^9.0.0 || ^10.0.0"
+
+# Version overrides: pmg auto-detects which deps are used, but these two need
+# non-default versions. `builtin-modules` is pinned to 3.3.0 (last CJS-compatible
+# release) because the plugin is compiled to CommonJS; the root package.json has
+# 5.0.0 (ESM-only) for the bridge. `typescript` is loosened to >=5 so consumers
+# aren't forced onto the exact version used to build.
+[data.dependencies]
+typescript = ">=5"
+builtin-modules = "3.3.0"

generate-eslint-package-json.mjs

@@ -0,0 +1,32 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2025 SonarSource Sàrl
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the Sonar Source-Available License for more details.
+ *
+ * You should have received a copy of the Sonar Source-Available License
+ * along with this program; if not, see https://sonarsource.com/license/ssal/
+ */
+const plugin = require('eslint-plugin-sonarjs');
+
+console.log(`Loaded ${Object.keys(plugin.configs.recommended.rules).length} rules`);
+
+module.exports = [
+  {
+    files: ['./*.js'],
+    languageOptions: { sourceType: 'commonjs' },
+  },
+  plugin.configs.recommended,
+  {
+    rules: {
+      'sonarjs/no-implicit-dependencies': 'error',
+    },
+  },
+];

its/eslint10-plugin-sonarjs/eslint.config.cjs

@@ -0,0 +1,32 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2011-2025 SonarSource Sàrl
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the Sonar Source-Available License for more details.
+ *
+ * You should have received a copy of the Sonar Source-Available License
+ * along with this program; if not, see https://sonarsource.com/license/ssal/
+ */
+import plugin from 'eslint-plugin-sonarjs';
+
+console.log(`Loaded ${Object.keys(plugin.configs.recommended.rules).length} rules`);
+
+export default [
+  {
+    files: ['./*.js'],
+    languageOptions: { sourceType: 'commonjs' },
+  },
+  plugin.configs.recommended,
+  {
+    rules: {
+      'sonarjs/no-implicit-dependencies': 'error',
+    },
+  },
+];