Skip to content

Commit 9f88174

Browse files
committed
Fix flaky npm mirror tarball test
`project_registry_decides_a_mirrors_tarball_urls` (added in #1466) checks the default-registry fallback, which reads SOCKET_NPM_REGISTRY. The bun lockb and vlt restore tests set that variable to a mock server, and they are serial, but this test was not, so it could run while one of them held the variable and fail. It knocked #1470 out of the merge queue on the coverage job. Mark it serial like the other tests that depend on the variable. Assisted-by: Claude Code:claude-opus-5-5
1 parent 501c6d9 commit 9f88174

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

  • crates/socket-patch-core/src/patch/redirect/upstream

‎crates/socket-patch-core/src/patch/redirect/upstream/npm.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4024,7 +4024,10 @@ mod tests {
40244024
);
40254025
}
40264026

4027+
// Serial: the default-registry fallback reads `SOCKET_NPM_REGISTRY`,
4028+
// which the serial bun and vlt restore tests point at a mock server.
40274029
#[test]
4030+
#[serial_test::serial]
40284031
fn project_registry_decides_a_mirrors_tarball_urls() {
40294032
// A metadata mirror that hands back the project registry's own URLs:
40304033
// the package manager derives them, so they stay out of the lock.

0 commit comments

Comments
 (0)