Skip to content

Commit 8fc25a3

Browse files
committed
Docs: name the tiers that run each Maven pin
The Maven vendoring design doc said the PR tier pins five Maven versions, but since lean CI only 3.9.16 runs on PRs and in the merge queue; the rest, plus 3.9.3 and 3.9.4, run in the nightly full tier. Also point two code comments that cite the Maven 4 release they were checked against at rc-7, which the e2e suites now run and pass on. Refs #267 Assisted-by: Claude Code:claude-opus-5-5
1 parent eda0d18 commit 8fc25a3

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

‎crates/socket-patch-cli/tests/maven_build_common/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ pub const MVN_ENV: &str = "SOCKET_PATCH_MAVEN_E2E_MVN";
3434
pub const VERSION_ENV: &str = "SOCKET_PATCH_MAVEN_E2E_VERSION";
3535
pub const REQUIRED_ENV: &str = "SOCKET_PATCH_MAVEN_E2E_REQUIRED";
3636

37-
/// What Maven 4's `CIDetector`s key on (4.0.0-rc-6 `cisupport`: generic
37+
/// What Maven 4's `CIDetector`s key on (4.0.0-rc-7 `cisupport`: generic
3838
/// `CI`, GitHub `GITHUB_ACTIONS`, CircleCI, Jenkins `WORKSPACE`, TeamCity,
3939
/// Travis). When one is set, Maven 4 swaps in the `QuietMavenTransferListener`
4040
/// even under `-B` — no "Downloading from …" lines and, crucially, no

‎crates/socket-patch-core/src/vex/discover/maven.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1547,7 +1547,7 @@ mod tests {
15471547

15481548
/// REGRESSION: the vendored repository is `checksumPolicy=fail`, so the
15491549
/// jar's `.sha1` sidecar is part of the wiring. With it stale or gone,
1550-
/// real Maven (3.6.3 → 4.0.0-rc-6, `e2e_vendor_maven_build`) rejects the
1550+
/// real Maven (3.6.3 → 4.0.0-rc-7, `e2e_vendor_maven_build`) rejects the
15511551
/// file:// copy and silently resolves Central's pristine jar — while the
15521552
/// committed members still hash-verify, so the ref must not attest a
15531553
/// build that no longer consumes the patch.

‎docs/design/maven-vendoring.md‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -248,11 +248,12 @@ integration tests. Real-tool capstones exercise a Maven reactor from fresh
248248
checkouts, root and module invocations, Gradle strict locking and repository
249249
mode, existing verification metadata, offline builds, tamper detection and
250250
byte-exact revert; `e2e_vendor_gradle_build` covers each Gradle rule above
251-
against a fake Central, asserting on the jar Gradle actually consumes. The PR
252-
tier pins Maven 3.6.3, 3.8.9, 3.9.2, 3.9.16 and 4.0.0-rc-7 (macOS and Windows on
253-
3.9.16), and Gradle 6.9.4, 7.6.6, 8.14.3 and 9.8.0 on Linux, plus a Windows
254-
8.14.3 row; `gradle-compatibility.yml` runs every Gradle version on Linux,
255-
macOS and Windows nightly.
251+
against a fake Central, asserting on the jar Gradle actually consumes. PR and
252+
merge-queue runs pin Maven 3.9.16; the nightly full tier adds 3.6.3, 3.8.9,
253+
3.9.2, 3.9.3, 3.9.4 and 4.0.0-rc-7 (macOS and Windows on 3.9.16), and Gradle
254+
6.9.4, 7.6.6, 8.14.3 and 9.8.0 on Linux, plus a Windows 8.14.3 row;
255+
`gradle-compatibility.yml` runs every Gradle version on Linux, macOS and
256+
Windows nightly.
256257

257258
Pre-v5 single-POM entries are not migrated: revert them and vendor again.
258259
Maven 4 implicit subproject discovery, build-time Maven strict pins, creating Gradle verification policy, and online

0 commit comments

Comments
 (0)