Repository navigation
Commit 2bf2c2e
committed
Keep real HOME and SOCKET_* off npm/Bun kids
From /code-review high: the Bun redirect suite ran its bun fixture
installs under the cache sandbox's home but the CLI under the real
one, so a registry or scope in the developer's ~/.npmrc would make
the two disagree. The CLI now gets the stand-in HOME
(jvm_env::isolate_cli), as run_with_env gives every other suite.
Its --no-telemetry flag goes: hermetic::command already forces
telemetry off, and the flag would override a caller opting back in.
e2e_npm's npm installs now drop ambient SOCKET_* vars too
(hermetic::scrub_socket_vars), like the package-manager children of
the other converted suites.
Refs #823
Assisted-by: Claude Code:claude-opus-5-51 parent 1d06435 commit 2bf2c2e
2 files changed
Lines changed: 11 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| 99 | + | |
99 | 100 | | |
100 | 101 | | |
101 | 102 | | |
| |||
345 | 346 | | |
346 | 347 | | |
347 | 348 | | |
| 349 | + | |
348 | 350 | | |
349 | 351 | | |
350 | 352 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
300 | 300 | | |
301 | 301 | | |
302 | 302 | | |
303 | | - | |
304 | | - | |
| 303 | + | |
| 304 | + | |
305 | 305 | | |
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
310 | | - | |
311 | | - | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
312 | 315 | | |
313 | 316 | | |
314 | | - | |
| 317 | + | |
315 | 318 | | |
| 319 | + | |
316 | 320 | | |
317 | 321 | | |
318 | 322 | | |
| |||
0 commit comments