Fix type check

Author: jdalton

src/utils/alert/rules.ts

@@ -186,18 +186,15 @@ export async function uxLookup(
         const orgResult = await sockSdk.getOrganizations()
         if (!orgResult.success) {
           if (orgResult.status === 429) {
-            throw new Error(
-              `API token quota exceeded: ${orgResult.error}`
-            )
+            throw new Error(`API token quota exceeded: ${orgResult.error}`)
           }
           throw new Error(
             `Failed to fetch Socket organization info: ${orgResult.error}`
           )
         }
         const { organizations } = orgResult.data
-        const orgs: Array<
-          Exclude<(typeof organizations)[string], undefined>
-        > = []
+        const orgs: Array<Exclude<(typeof organizations)[string], undefined>> =
+          []
         for (const org of Object.values(organizations)) {
           if (org) {
             orgs.push(org)

src/utils/api.ts

@@ -16,17 +16,14 @@ import type {
 
 export function handleUnsuccessfulApiResponse<T extends SocketSdkOperations>(
   _name: T,
-  result: SocketSdkErrorType<T>
+  sockSdkError: SocketSdkErrorType<T>
 ): never {
-  // SocketSdkErrorType['error'] is not typed.
-  const resultErrorMessage = (result as { error?: Error }).error?.message
-  const message =
-    typeof resultErrorMessage === 'string'
-      ? resultErrorMessage
-      : 'No error message returned'
-  if (result.status === 401 || result.status === 403) {
+  const message = sockSdkError.error || 'No error message returned'
+  const { status } = sockSdkError
+  if (status === 401 || status === 403) {
     // Lazily access constants.spinner.
     const { spinner } = constants
+
     spinner.stop()
 
     throw new AuthError(message)