refactor(debug): route API failure logs through the error namespace

Author: jdalton

packages/cli/src/utils/debug.mts

@@ -98,7 +98,7 @@ function buildApiDebugDetails(
   requestInfo?: ApiRequestDebugInfo | undefined,
 ): Record<string, unknown> {
   // `__proto__: null` keeps the payload free of prototype-chain keys
-  // when callers iterate over `debugDir`'s output.
+  // when callers iterate over the debug output.
   const details: Record<string, unknown> = { __proto__: null, ...base } as Record<string, unknown>
   if (!requestInfo) {
     return details
@@ -143,9 +143,9 @@ function buildApiDebugDetails(
 }
 
 /**
- * Debug an API response. Only failed requests (error or status >= 400)
- * produce structured output; successful responses optionally log a
- * one-liner at the `notice` debug namespace.
+ * Debug an API response. Failed requests (error or status >= 400) log
+ * under the `error` namespace; successful responses optionally log a
+ * one-liner under `notice`.
  *
  * Request and response headers are sanitized via `sanitizeHeaders` so
  * Authorization and `*api-key*` values are redacted.
@@ -157,7 +157,8 @@ export function debugApiResponse(
   requestInfo?: ApiRequestDebugInfo | undefined,
 ): void {
   if (error) {
-    debugDir(
+    debugDirNs(
+      'error',
       buildApiDebugDetails(
         {
           endpoint,
@@ -168,9 +169,9 @@ export function debugApiResponse(
     )
   } else if (status && status >= 400) {
     if (requestInfo) {
-      debugDir(buildApiDebugDetails({ endpoint, status }, requestInfo))
+      debugDirNs('error', buildApiDebugDetails({ endpoint, status }, requestInfo))
     } else {
-      debug(`API ${endpoint}: HTTP ${status}`)
+      debugNs('error', `API ${endpoint}: HTTP ${status}`)
     }
     /* c8 ignore next 3 */
   } else if (isDebugNs('notice')) {

packages/cli/test/unit/utils/debug.test.mts

@@ -97,16 +97,16 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/test', undefined, error)
 
-      expect(debugDir).toHaveBeenCalledWith({
+      expect(mockDebugDirNs).toHaveBeenCalledWith('error', {
         endpoint: '/api/test',
         error: 'API failed',
       })
     })
 
-    it('logs warning for HTTP error status codes', () => {
+    it('logs under error namespace for HTTP error status codes', () => {
       debugApiResponse('/api/test', 404)
 
-      expect(debug).toHaveBeenCalledWith('API /api/test: HTTP 404')
+      expect(debugNs).toHaveBeenCalledWith('error', 'API /api/test: HTTP 404')
     })
 
     it('logs notice for successful responses when debug is enabled', () => {
@@ -128,7 +128,7 @@ describe('debug utilities', () => {
     it('handles non-Error objects in error parameter', () => {
       debugApiResponse('/api/test', undefined, 'String error')
 
-      expect(debugDir).toHaveBeenCalledWith({
+      expect(mockDebugDirNs).toHaveBeenCalledWith('error', {
         endpoint: '/api/test',
         error: 'Unknown error',
       })
@@ -148,7 +148,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/test', undefined, error, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.method).toBe('POST')
       expect(calledWith.url).toBe('https://api.socket.dev/test')
       expect(calledWith.durationMs).toBe(1500)
@@ -169,7 +169,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/resource', 500, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.status).toBe(500)
       expect(calledWith.method).toBe('GET')
       // API key should be redacted.
@@ -183,7 +183,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/update', 400, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.method).toBe('PUT')
       expect(calledWith.url).toBeUndefined()
       expect(calledWith.headers).toBeUndefined()
@@ -198,7 +198,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/x', 500, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.requestedAt).toBe('2026-04-18T00:00:00.000Z')
     })
 
@@ -214,7 +214,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/y', 500, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.cfRay).toBe('abc123-IAD')
       expect(calledWith.responseHeaders?.['cf-ray']).toBe('abc123-IAD')
     })
@@ -230,7 +230,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/z', 500, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.cfRay).toBe('xyz789-SJC')
     })
 
@@ -243,7 +243,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/body', 400, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.responseBody).toBe('{"error":"bad"}')
     })
 
@@ -257,7 +257,7 @@ describe('debug utilities', () => {
 
       debugApiResponse('/api/big', 500, undefined, requestInfo)
 
-      const calledWith = mockDebugDir.mock.calls[0]?.[0]
+      const calledWith = mockDebugDirNs.mock.calls[0]?.[1] as any
       expect(calledWith.responseBody).toMatch(/… \(truncated, 5000 chars\)$/)
       expect((calledWith.responseBody as string).length).toBeLessThan(
         bigBody.length,