Cleanup checkCommandInput

Author: jdalton

src/commands/analytics/cmd-analytics.mts

@@ -111,14 +111,12 @@ async function run(
       nook: true,
       test: noLegacy,
       message: 'Legacy flags are no longer supported. See v1 migration guide.',
-      pass: 'ok',
       fail: `received legacy flags`,
     },
     {
       nook: true,
       test: scope === 'org' || !!repoName,
       message: 'When scope=repo, repo name should be the second argument',
-      pass: 'ok',
       fail: 'missing',
     },
     {
@@ -127,37 +125,32 @@ async function run(
         scope === 'org' ||
         (repoName !== '7' && repoName !== '30' && repoName !== '90'),
       message: 'When scope is repo, the second arg should be repo, not time',
-      pass: 'ok',
       fail: 'missing',
     },
     {
       test: time === '7' || time === '30' || time === '90',
       message: 'The time filter must either be 7, 30 or 90',
-      pass: 'ok',
       fail: 'invalid range set, see --help for command arg details.',
     },
     {
       nook: true,
       test: !file || !!json || !!markdown,
       message:
         'The `--file` flag is only valid when using `--json` or `--markdown`',
-      pass: 'ok',
       fail: 'bad',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
     {
       nook: true,
       test: hasApiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
-      pass: 'ok',
       fail: 'missing Socket API token',
     },
   )

src/commands/audit-log/cmd-audit-log.mts

@@ -123,37 +123,32 @@ async function run(
       nook: true,
       test: noLegacy,
       message: 'Legacy flags are no longer supported. See v1 migration guide.',
-      pass: 'ok',
       fail: `received legacy flags`,
     },
     {
       nook: true,
       test: !!orgSlug,
       message: 'Org name by default setting, --org, or auto-discovered',
-      pass: 'ok',
       fail: 'missing',
     },
     {
       nook: true,
       test: hasApiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
-      pass: 'ok',
       fail: 'missing Socket API token',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
     {
       nook: true,
       test: /^[a-zA-Z]*$/.test(typeFilter),
       message: 'The filter must be an a-zA-Z string, it is an enum',
-      pass: 'ok',
       fail: 'it was given but not a-zA-Z',
     },
   )

src/commands/config/cmd-config-auto.mts

@@ -77,15 +77,13 @@ ${getSupportedConfigEntries()
     {
       test: key !== 'test' && isSupportedConfigKey(key),
       message: 'Config key should be the first arg',
-      pass: 'ok',
       fail: key ? 'invalid config key' : 'missing',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
   )

src/commands/config/cmd-config-get.mts

@@ -75,15 +75,13 @@ async function run(
     {
       test: key === 'test' || isSupportedConfigKey(key),
       message: 'Config key should be the first arg',
-      pass: 'ok',
       fail: key ? 'invalid config key' : 'missing',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
   )

src/commands/config/cmd-config-list.mts

@@ -64,7 +64,6 @@ async function run(
     test: !json || !markdown,
     message:
       'The `--json` and `--markdown` flags can not be used at the same time',
-    pass: 'ok',
     fail: 'bad',
   })
   if (!wasValidInput) {

src/commands/config/cmd-config-set.mts

@@ -86,22 +86,19 @@ ${getSupportedConfigEntries()
     {
       test: key === 'test' || isSupportedConfigKey(key),
       message: 'Config key should be the first arg',
-      pass: 'ok',
       fail: key ? 'invalid config key' : 'missing',
     },
     {
       test: !!value, // This is a string, empty string is not ok
       message:
         'Key value should be the remaining args (use `unset` to unset a value)',
-      pass: 'ok',
       fail: 'missing',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
   )

src/commands/config/cmd-config-unset.mts

@@ -78,15 +78,13 @@ ${getSupportedConfigEntries()
     {
       test: key === 'test' || isSupportedConfigKey(key),
       message: 'Config key should be the first arg',
-      pass: 'ok',
       fail: key ? 'invalid config key' : 'missing',
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
   )

src/commands/fix/cmd-fix.mts

@@ -174,7 +174,6 @@ async function run(
   const wasValidInput = checkCommandInput(outputKind, {
     test: RangeStyles.includes(rangeStyle),
     message: `Expecting range style of ${joinOr(RangeStyles)}`,
-    pass: 'ok',
     fail: 'invalid',
   })
   if (!wasValidInput) {

src/commands/manifest/cmd-manifest-conda.mts

@@ -157,15 +157,13 @@ async function run(
       nook: true,
       test: cli.input.length <= 1,
       message: 'Can only accept one DIR (make sure to escape spaces!)',
-      pass: 'ok',
       fail: `received ${cli.input.length}`,
     },
     {
       nook: true,
       test: !json || !markdown,
       message:
         'The `--json` and `--markdown` flags can not be used at the same time',
-      pass: 'ok',
       fail: 'bad',
     },
   )

src/commands/manifest/cmd-manifest-gradle.mts

@@ -147,7 +147,6 @@ async function run(
     nook: true,
     test: cli.input.length <= 1,
     message: 'Can only accept one DIR (make sure to escape spaces!)',
-    pass: 'ok',
     fail: 'received ' + cli.input.length,
   })
   if (!wasValidInput) {