fix(api): include request path in API error messages (#1224)

* fix(api): include request path in API error messages

Backport of v1.x #1094 to main. When a Socket API request fails,
we now always surface the endpoint path in the error message — not
just on the non-ok-response branch where we already had it.

Specifically:
  * `queryApiSafeText` catch block (network error) — append `(path: ${path})`
  * `queryApiSafeText` response-text-read catch — append `(path: ${path})`
  * `sendApiRequest` catch block (network error) — append `(path: ${path})`
  * `sendApiRequest` JSON-parse catch — append `(path: ${path})`

The `handleApiCall` / `handleApiCallNoSpinner` paths already include
`(endpoint: ${description})` so no change there.

Closes the coverage gap flagged in the v1.x changelog: "This lacks the
request URL, making it difficult to debug which endpoint failed."

* test(api): assert (path: …) suffix on error causes

The original #1224 change added `(path: <path>)` to four error causes
but the existing tests only asserted loose substrings like "failed" /
"parsing" / "response text", so a regression would slip by unnoticed.

Adds four targeted assertions inside the existing tests:
  * queryApiSafeText — network-failure branch
  * queryApiSafeText — text-read-failure branch
  * sendApiRequest — network-failure branch
  * sendApiRequest — JSON-parse-failure branch

Each now verifies `result.cause` contains `(path: test/path)`. No new
tests added — the existing ones already set up the right mocks for
each failure mode, so extending the assertion is the minimum change
to actually lock the behavior in.

Author: jdalton

packages/cli/src/utils/socket/api.mts

@@ -465,7 +465,7 @@ export async function queryApiSafeText(
     return {
       ok: false,
       message,
-      cause: networkDiagnostics,
+      cause: `${networkDiagnostics} (path: ${path})`,
     }
   }
 
@@ -506,7 +506,7 @@ export async function queryApiSafeText(
     return {
       ok: false,
       message: 'API request failed',
-      cause: 'Unexpected error reading response text',
+      cause: `Unexpected error reading response text (path: ${path})`,
     }
   }
 }
@@ -643,7 +643,7 @@ export async function sendApiRequest<T>(
     return {
       ok: false,
       message,
-      cause: networkDiagnostics,
+      cause: `${networkDiagnostics} (path: ${path})`,
     }
   }
 
@@ -686,7 +686,7 @@ export async function sendApiRequest<T>(
     return {
       ok: false,
       message: 'API request failed',
-      cause: 'Unexpected error parsing response JSON',
+      cause: `Unexpected error parsing response JSON (path: ${path})`,
     }
   }
 }

packages/cli/test/unit/utils/socket/api.test.mts

@@ -469,6 +469,9 @@ describe('api utilities', () => {
       expect(result.ok).toBe(false)
       if (!result.ok) {
         expect(result.message).toContain('failed')
+        // The cause must include the request path so the user can tell
+        // which endpoint failed when several calls are in flight.
+        expect(result.cause).toContain('(path: test/path)')
       }
       expect(mockFailAndStop).toHaveBeenCalled()
     })
@@ -493,6 +496,7 @@ describe('api utilities', () => {
       expect(result.ok).toBe(false)
       if (!result.ok) {
         expect(result.cause).toContain('response text')
+        expect(result.cause).toContain('(path: test/path)')
       }
     })
   })
@@ -628,6 +632,8 @@ describe('api utilities', () => {
       expect(result.ok).toBe(false)
       if (!result.ok) {
         expect(result.message).toContain('failed')
+        // Request path must be surfaced in error cause for debuggability.
+        expect(result.cause).toContain('(path: test/path)')
       }
     })
 
@@ -642,6 +648,7 @@ describe('api utilities', () => {
       expect(result.ok).toBe(false)
       if (!result.ok) {
         expect(result.cause).toContain('parsing')
+        expect(result.cause).toContain('(path: test/path)')
       }
     })