chore(build): drop minification from index bundler (#1215)

Removes the partial-minify branch (minifyWhitespace/minifyIdentifiers)
in createIndexConfig so the index loader is produced unminified, matching
the rest of the prod build config. Also drops the now-redundant
`minify: false` from the package-builder templates that called it.

Rationale: simpler, one shape of output, easier for contributors to read.

Author: jdalton

packages/cli/scripts/esbuild-utils.mts

@@ -20,10 +20,9 @@ const logger = getDefaultLogger()
  * @param {Object} options - Configuration options
  * @param {string} options.entryPoint - Path to entry point file
  * @param {string} options.outfile - Path to output file
- * @param {boolean} [options.minify=false] - Whether to minify output
  * @returns {Object} esbuild configuration object
  */
-export function createIndexConfig({ entryPoint, minify = false, outfile }: { entryPoint: string; minify?: boolean; outfile: string }) {
+export function createIndexConfig({ entryPoint, outfile }: { entryPoint: string; outfile: string }) {
   // Get inlined environment variables for build-time constant replacement.
   const inlinedEnvVars = getInlinedEnvVars()
 
@@ -34,6 +33,7 @@ export function createIndexConfig({ entryPoint, minify = false, outfile }: { ent
     bundle: true,
     entryPoints: [entryPoint],
     format: 'cjs',
+    minify: false,
     outfile,
     platform: 'node',
     // Source maps off for entry point production build.
@@ -50,13 +50,6 @@ export function createIndexConfig({ entryPoint, minify = false, outfile }: { ent
     write: false,
   }
 
-  if (minify) {
-    config.minify = true
-  } else {
-    config.minifyWhitespace = true
-    config.minifyIdentifiers = true
-  }
-
   return config
 }
 

packages/package-builder/templates/cli-package/.config/esbuild.index.mts

@@ -18,7 +18,6 @@ const cliPath = path.resolve(__dirname, '../../cli')
 const config = createIndexConfig({
   entryPoint: path.join(cliPath, 'src', 'index.mts'),
   outfile: path.join(rootPath, 'dist', 'index.js'),
-  minify: false,
 })
 
 if (fileURLToPath(import.meta.url) === process.argv[1]) {

packages/package-builder/templates/cli-sentry-package/.config/esbuild.index.mts

@@ -18,7 +18,6 @@ const cliPath = path.resolve(__dirname, '../../cli')
 const config = createIndexConfig({
   entryPoint: path.join(cliPath, 'src', 'index.mts'),
   outfile: path.join(rootPath, 'dist', 'index.js'),
-  minify: false,
 })
 
 if (fileURLToPath(import.meta.url) === process.argv[1]) {