Skip to content

Commit 2e9e9a8

Browse files
dc-larsenlelia
dc-larsen
and
lelia
authored
Fix webhook notifier not reading URL from dashboard config (#34)
* Fix webhook notifier not reading URL from dashboard config WebhookNotifier.__init__ read self.config.get('url') but the param resolved from notifications.yaml and app_config uses the key 'webhook_url'. This caused dashboard-configured webhook URLs to be silently ignored, logging "no webhook URL configured" at send time even though the notifier loaded successfully. Aligns the config key with the parameter name, matching the pattern used by JiraNotifier and other notifiers. Env var fallback (INPUT_WEBHOOK_URL) is unaffected. * Tweak webhook notifier tests to ensure clear env before each test Signed-off-by: lelia <lelia@socket.dev> * Bump version to prep for release Signed-off-by: lelia <lelia@socket.dev> --------- Signed-off-by: lelia <lelia@socket.dev> Co-authored-by: lelia <lelia@socket.dev>
1 parent f0099a5 commit 2e9e9a8

10 files changed

Lines changed: 152 additions & 65 deletions

File tree

‎README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
steps:
3434
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
3535
- name: Run Socket Basics
36-
uses: SocketDev/socket-basics@1.1.0
36+
uses: SocketDev/socket-basics@1.1.1
3737
env:
3838
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
3939
with:
@@ -144,10 +144,10 @@ For GitHub Actions, see the [Quick Start](#-quick-start---github-actions) above
144144

145145
```bash
146146
# Build with version tag
147-
docker build -t socketdev/socket-basics:1.1.0 .
147+
docker build -t socketdev/socket-basics:1.1.1 .
148148
149149
# Run scan
150-
docker run --rm -v "$PWD:/workspace" socketdev/socket-basics:1.1.0 \
150+
docker run --rm -v "$PWD:/workspace" socketdev/socket-basics:1.1.1 \
151151
--workspace /workspace \
152152
--python-sast-enabled \
153153
--secret-scanning-enabled \
@@ -160,7 +160,7 @@ Tip: If you need specific Trivy or TruffleHog versions, you can override them at
160160
docker build \
161161
--build-arg TRIVY_VERSION=v0.67.2 \
162162
--build-arg TRUFFLEHOG_VERSION=v3.93.3 \
163-
-t socketdev/socket-basics:1.1.0 .
163+
-t socketdev/socket-basics:1.1.1 .
164164
```
165165

166166
📖 **[View Docker Installation Guide](docs/local-install-docker.md)**

‎docs/github-action.md‎

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
steps:
4343
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
4444
- name: Run Socket Basics
45-
uses: SocketDev/socket-basics@1.1.0
45+
uses: SocketDev/socket-basics@1.1.1
4646
env:
4747
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
4848
with:
@@ -77,7 +77,7 @@ Include these in your workflow's `jobs.<job_id>.permissions` section.
7777

7878
**SAST (Static Analysis):**
7979
```yaml
80-
- uses: SocketDev/socket-basics@1.1.0
80+
- uses: SocketDev/socket-basics@1.1.1
8181
with:
8282
github_token: ${{ secrets.GITHUB_TOKEN }}
8383
# Enable SAST for specific languages
@@ -91,7 +91,7 @@ Include these in your workflow's `jobs.<job_id>.permissions` section.
9191

9292
**Secret Scanning:**
9393
```yaml
94-
- uses: SocketDev/socket-basics@1.1.0
94+
- uses: SocketDev/socket-basics@1.1.1
9595
with:
9696
github_token: ${{ secrets.GITHUB_TOKEN }}
9797
secret_scanning_enabled: 'true'
@@ -103,7 +103,7 @@ Include these in your workflow's `jobs.<job_id>.permissions` section.
103103

104104
**Container Scanning:**
105105
```yaml
106-
- uses: SocketDev/socket-basics@1.1.0
106+
- uses: SocketDev/socket-basics@1.1.1
107107
with:
108108
github_token: ${{ secrets.GITHUB_TOKEN }}
109109
# Scan Docker images (auto-enables container scanning)
@@ -114,7 +114,7 @@ Include these in your workflow's `jobs.<job_id>.permissions` section.
114114

115115
**Socket Tier 1 Reachability:**
116116
```yaml
117-
- uses: SocketDev/socket-basics@1.1.0
117+
- uses: SocketDev/socket-basics@1.1.1
118118
with:
119119
github_token: ${{ secrets.GITHUB_TOKEN }}
120120
socket_tier_1_enabled: 'true'
@@ -123,7 +123,7 @@ Include these in your workflow's `jobs.<job_id>.permissions` section.
123123
### Output Configuration
124124

125125
```yaml
126-
- uses: SocketDev/socket-basics@1.1.0
126+
- uses: SocketDev/socket-basics@1.1.1
127127
with:
128128
github_token: ${{ secrets.GITHUB_TOKEN }}
129129
python_sast_enabled: 'true'
@@ -159,7 +159,7 @@ Configure Socket Basics centrally from the [Socket Dashboard](https://socket.dev
159159

160160
**Enable in workflow:**
161161
```yaml
162-
- uses: SocketDev/socket-basics@1.1.0
162+
- uses: SocketDev/socket-basics@1.1.1
163163
env:
164164
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
165165
with:
@@ -171,7 +171,7 @@ Configure Socket Basics centrally from the [Socket Dashboard](https://socket.dev
171171

172172
> **Note:** You can also pass credentials using environment variables instead of the `with:` section:
173173
> ```yaml
174-
> - uses: SocketDev/socket-basics@1.1.0
174+
> - uses: SocketDev/socket-basics@1.1.1
175175
> env:
176176
> SOCKET_SECURITY_API_KEY: ${{ secrets.SOCKET_SECURITY_API_KEY }}
177177
> with:
@@ -189,7 +189,7 @@ All notification integrations require Socket Enterprise.
189189

190190
**Slack Notifications:**
191191
```yaml
192-
- uses: SocketDev/socket-basics@1.1.0
192+
- uses: SocketDev/socket-basics@1.1.1
193193
with:
194194
github_token: ${{ secrets.GITHUB_TOKEN }}
195195
socket_org: ${{ secrets.SOCKET_ORG }}
@@ -201,7 +201,7 @@ All notification integrations require Socket Enterprise.
201201

202202
**Jira Issue Creation:**
203203
```yaml
204-
- uses: SocketDev/socket-basics@1.1.0
204+
- uses: SocketDev/socket-basics@1.1.1
205205
with:
206206
github_token: ${{ secrets.GITHUB_TOKEN }}
207207
socket_org: ${{ secrets.SOCKET_ORG }}
@@ -216,7 +216,7 @@ All notification integrations require Socket Enterprise.
216216

217217
**Microsoft Teams:**
218218
```yaml
219-
- uses: SocketDev/socket-basics@1.1.0
219+
- uses: SocketDev/socket-basics@1.1.1
220220
with:
221221
github_token: ${{ secrets.GITHUB_TOKEN }}
222222
socket_org: ${{ secrets.SOCKET_ORG }}
@@ -228,7 +228,7 @@ All notification integrations require Socket Enterprise.
228228

229229
**Generic Webhook:**
230230
```yaml
231-
- uses: SocketDev/socket-basics@1.1.0
231+
- uses: SocketDev/socket-basics@1.1.1
232232
with:
233233
github_token: ${{ secrets.GITHUB_TOKEN }}
234234
socket_org: ${{ secrets.SOCKET_ORG }}
@@ -240,7 +240,7 @@ All notification integrations require Socket Enterprise.
240240

241241
**SIEM Integration:**
242242
```yaml
243-
- uses: SocketDev/socket-basics@1.1.0
243+
- uses: SocketDev/socket-basics@1.1.1
244244
with:
245245
github_token: ${{ secrets.GITHUB_TOKEN }}
246246
socket_org: ${{ secrets.SOCKET_ORG }}
@@ -276,7 +276,7 @@ jobs:
276276
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
277277
278278
- name: Run Socket Basics
279-
uses: SocketDev/socket-basics@1.1.0
279+
uses: SocketDev/socket-basics@1.1.1
280280
env:
281281
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
282282
with:
@@ -322,7 +322,7 @@ jobs:
322322
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
323323
324324
- name: Run Full Security Scan
325-
uses: SocketDev/socket-basics@1.1.0
325+
uses: SocketDev/socket-basics@1.1.1
326326
env:
327327
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
328328
with:
@@ -373,10 +373,10 @@ jobs:
373373
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
374374
375375
- name: Build Docker Image
376-
run: docker build -t myapp:1.1.0:${{ github.sha }} .
376+
run: docker build -t myapp:1.1.1:${{ github.sha }} .
377377
378378
- name: Scan Container
379-
uses: SocketDev/socket-basics@1.1.0
379+
uses: SocketDev/socket-basics@1.1.1
380380
env:
381381
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
382382
with:
@@ -439,7 +439,7 @@ jobs:
439439
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
440440
441441
- name: Run Socket Basics
442-
uses: SocketDev/socket-basics@1.1.0
442+
uses: SocketDev/socket-basics@1.1.1
443443
env:
444444
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
445445
with:
@@ -491,7 +491,7 @@ jobs:
491491
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
492492
493493
- name: Run Socket Basics
494-
uses: SocketDev/socket-basics@1.1.0
494+
uses: SocketDev/socket-basics@1.1.1
495495
env:
496496
GITHUB_PR_NUMBER: ${{ github.event.pull_request.number || github.event.issue.number }}
497497
with:
@@ -584,7 +584,7 @@ env:
584584
```yaml
585585
steps:
586586
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - Must be first
587-
- uses: SocketDev/socket-basics@1.1.0
587+
- uses: SocketDev/socket-basics@1.1.1
588588
```
589589

590590
### PR Comments Not Appearing

0 commit comments

Comments
 (0)