Skip to content

Commit ac17e0f

Browse files
Revert AWS version
1 parent 9e790ab commit ac17e0f

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

src/ImageSharp.Web.Providers.AWS/ImageSharp.Web.Providers.AWS.csproj

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@
3131
</ItemGroup>
3232

3333
<ItemGroup>
34-
<PackageReference Include="AWSSDK.S3" Version="3.7.8.8" />
34+
<!--TODO: Do not upgrade this. Makes CI tests flaky-->
35+
<PackageReference Include="AWSSDK.S3" Version="3.7.7.16" />
3536
</ItemGroup>
3637

3738
<ItemGroup>

src/ImageSharp.Web.Providers.Azure/ImageSharp.Web.Providers.Azure.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
</ItemGroup>
3232

3333
<ItemGroup>
34-
<!--Do not upgrade this. Last Version that supports .NET Core 2.1-->
34+
<!--TODO: Do not upgrade this. Last Version that supports .NET Core 2.1-->
3535
<PackageReference Include="Azure.Storage.Blobs" Version="12.10.0" />
3636
</ItemGroup>
3737

tests/ImageSharp.Web.Tests/Processing/AWSS3StorageCacheServerTests.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,9 @@ public async Task CanProcessAndResolveImageAsync(string url)
7676

7777
response = await this.HttpClient.SendAsync(request);
7878

79-
#if !ENV_CI
80-
// TODO: This test is flaky in the CI environment when testing
81-
// and sometimes returns an OK response. Likely due to the 3rd party AWS shim.
8279
Assert.Equal(HttpStatusCode.NotModified, response.StatusCode);
8380
Assert.Equal(0, response.Content.Headers.ContentLength);
8481
Assert.Equal(format.DefaultMimeType, response.Content.Headers.ContentType.MediaType);
85-
#endif
8682

8783
request.Dispose();
8884
response.Dispose();

0 commit comments

Comments
 (0)