Skip to content

Commit 38c55af

Browse files
authored
Merge pull request #1308 from elizasorber/adding_indifferent_access_issue_1296
Adding indifferent access
2 parents 6a74e1e + 39e7e85 commit 38c55af

3 files changed

Lines changed: 6 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Note: For changes to the API, see https://shopify.dev/changelog?filter=api
55
## Unreleased
66

77
- [#1327](https://github.com/Shopify/shopify-api-ruby/pull/1327) Support `?debug=true` parameter in GraphQL client requests
8+
- [#1308](https://github.com/Shopify/shopify-api-ruby/pull/1308) Support hash_with_indifferent_access when creating REST objects from Shopify responses. Closes #1296
89

910
## 14.4.0
1011

lib/shopify_api/rest/base.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
# frozen_string_literal: true
33

44
require "active_support/inflector"
5+
require "active_support/core_ext/hash/indifferent_access"
56

67
module ShopifyAPI
78
module Rest
@@ -248,7 +249,7 @@ def request(http_method:, operation:, session:, ids: {}, params: {}, body: nil,
248249
def create_instances_from_response(response:, session:)
249250
objects = []
250251

251-
body = T.cast(response.body, T::Hash[String, T.untyped])
252+
body = T.cast(response.body, T::Hash[String, T.untyped]).with_indifferent_access
252253

253254
response_names = json_response_body_names
254255

sorbet/rbi/shims/hash.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
class Hash
2+
def with_indifferent_access; end
3+
end

0 commit comments

Comments
 (0)