fix(s032): the smoke run asked for by TRINITY_SMOKE=1, so Kernel.CLI has no argument to mistake for a file

Package run 35608084951, macOS: 'No file named --smoke', exit 1, between the fourth line
and the fifth. The workflow sets the variable; --smoke still works where the race is won.

Signed-off-by: Ayla Croft <aylacroft@proton.me>

Author: HackTuah

.github/workflows/package.yml

@@ -192,7 +192,10 @@ jobs:
           ours() { ps -eo pid,ppid,comm | grep -E 'burrito|beam\.smp|erl_child_setup|desktop_' | grep -v grep || true; }
           ours > ps-before.txt
           chmod +x "burrito_out/${{ matrix.artifact }}"
-          "./burrito_out/${{ matrix.artifact }}" --no-halt --smoke | tee smoke.log
+          # Slice 032: the variable, not `--smoke`: Kernel.CLI read the argument as a file
+          # ("No file named --smoke", exit 1) and won the race against the halting Task on
+          # macOS in run 35608084951.
+          TRINITY_SMOKE=1 "./burrito_out/${{ matrix.artifact }}" --no-halt | tee smoke.log
           sleep 3
           ours > ps-after.txt
           grep -q '^TRINITY_SMOKE_PORT=[0-9][0-9]*$' smoke.log
@@ -212,7 +215,8 @@ jobs:
         shell: pwsh
         run: |
           $ErrorActionPreference = "Stop"
-          & ".\burrito_out\${{ matrix.artifact }}" --no-halt --smoke | Tee-Object smoke.log
+          $env:TRINITY_SMOKE = "1"
+          & ".\burrito_out\${{ matrix.artifact }}" --no-halt | Tee-Object smoke.log
           if ($LASTEXITCODE -ne 0) { throw "smoke exited $LASTEXITCODE" }
           if (-not (Select-String -Path smoke.log -Pattern '^TRINITY_SMOKE_PORT=\d+$')) {
             throw "no port line"

config/runtime.exs

@@ -24,7 +24,9 @@ import Config
 # which is the same call: this file is evaluated before the application is available under
 # Mix, so it may not call project modules. `Burrito.Util.Args.get_arguments/0` reads the same
 # thing.
-smoke? = "--smoke" in Enum.map(:init.get_plain_arguments(), &to_string/1)
+smoke? =
+  "--smoke" in Enum.map(:init.get_plain_arguments(), &to_string/1) or
+    System.get_env("TRINITY_SMOKE") == "1"
 
 if System.get_env("PHX_SERVER") || smoke? do
   config :trinity, TrinityWeb.Endpoint, server: true

docs/packaging.md

@@ -66,6 +66,15 @@ nothing downstream notices.
 process. It is the only part of "the desktop app works" that a terminal can answer on a machine
 with no display.
 
+As built at slice 032, `TRINITY_SMOKE=1` in the environment asks for the same run and is the form
+the package workflow uses: `Kernel.CLI` reads the plain arguments once the application has started
+and treats `--smoke` as a file to run ("No file named --smoke", exit 1), a race the halting Task
+lost on macOS in run 35608084951. The run prints five lines: the port, the markdown renderer
+(slice 013), whether the EXLA NIF loaded (`TRINITY_SMOKE_EXLA`, recorded), a fake-vector search
+through the vector store in force on the binary's own database, rolled back (`TRINITY_SMOKE_VEC`,
+binding: exit 4), and the semantic tier's status (`TRINITY_SMOKE_SEMANTIC`, recorded). Slice
+032's PROOF.md AC7 has each bundle's answers.
+
 ## Measurements: linux x86_64 only
 
 Machine: Linux 6.14.0-37-generic, x86_64. **These figures are for this host and this target.**

lib/trinity/smoke.ex

@@ -44,9 +44,17 @@ defmodule Trinity.Smoke do
   @spec argv() :: [String.t()]
   def argv, do: Enum.map(:init.get_plain_arguments(), &to_string/1)
 
-  @doc "Whether `#{@flag}` was passed."
+  @doc """
+  Whether the smoke run was asked for: `#{@flag}` among the arguments, or `TRINITY_SMOKE=1` in
+  the environment. The variable is the form the package workflow uses since slice 032:
+  `Kernel.CLI` reads the same plain arguments once the application has started and treats
+  `#{@flag}` as a file to run ("No file named --smoke", exit 1), and the Task that prints the
+  lines and halts wins that race only sometimes (package run 35608084951, macOS: exit 1
+  between the fourth line and the fifth). An environment variable is nothing for the CLI to
+  read.
+  """
   @spec requested?([String.t()]) :: boolean()
-  def requested?(args), do: @flag in args
+  def requested?(args), do: @flag in args or System.get_env("TRINITY_SMOKE") == "1"
 
   @doc """
   The line printed for the caller to parse. One key=value pair, no prose around it, so a shell

test/smoke_test.exs

@@ -29,6 +29,16 @@ defmodule SmokeTest do
       refute Smoke.requested?(["--smoked"])
       refute Smoke.requested?(["smoke"])
     end
+
+    # Slice 032: the variable form, which Kernel.CLI cannot mistake for a file.
+    test "true with TRINITY_SMOKE=1 and no argument" do
+      System.put_env("TRINITY_SMOKE", "1")
+      on_exit(fn -> System.delete_env("TRINITY_SMOKE") end)
+      assert Smoke.requested?([])
+      assert Smoke.probe([]) == [Trinity.Smoke.Probe]
+      System.put_env("TRINITY_SMOKE", "0")
+      refute Smoke.requested?([])
+    end
   end
 
   describe "port_line/1" do