Repository navigation
Commit a7630ba
committed
fix(s080): the panel told two lies, and the screenshot is what caught them
AC7 is this slice's one manual criterion and it earned its place on the first
run. The panel looked right and reported two things wrongly, and no test saw
either, because the tests asserted that rows appeared rather than that the rows
were true.
Every child was labelled active, including the three that had finished, each with
a stop button offering to stop work that was over. The panel read
SessionRow.status, which is the session lifecycle - active, archived, compacted -
and stays active forever after a subagent finishes. It promised which are running
and delivered which are not archived. Running state now comes from the process.
All four short ids read the same eight characters. These ids are UUIDv7 and
time-ordered, so children created in the same second share their leading bytes:
measured, four ids generated together had one distinct 8-character prefix between
them. A short id whose only job is to tell two rows apart has to come from the
random end, so short_id/1 takes the tail.
The first fix was then wrong in the other direction, and the tests caught that
one: Sessions.state/1 answers with a view map rather than a bare state atom, so
comparing it to :idle was true for every child and the panel reported everything
as running.
Two defects in my own tests, both found by running the suite rather than the
file. await_child returns as soon as the child row exists, which create_child/3
inserts before the turn starts, so asserting running? on the next line raced the
process it asked about. And ConnCase does not stop the session processes a test
starts, so a child left running held the sandbox connection past its owner and
failed the next test's setup rather than its own, which is the same shape of leak
slice 025 found in persistent_term.
scripts/dev_subagents.sh runs the demo the screenshot was taken from. It migrates
both repositories before the application starts rather than after, because Oban
verifies its migration as it boots and a run that migrates afterwards never gets
that far.
Both screenshots are kept, before and after, because the difference between them
is the argument for the criterion being manual.
mix gate exit 0; 639 passed; coverage 80.31%.
Signed-off-by: Ayla Croft <aylacroft@proton.me>1 parent acec0e8 commit a7630ba
4 files changed
Lines changed: 180 additions & 13 deletions
File tree
- lib
- trinity_web/live/session_live
- trinity
- scripts
- test/trinity_web/live
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
125 | 160 | | |
126 | 161 | | |
127 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
139 | 148 | | |
140 | 149 | | |
141 | 150 | | |
| |||
148 | 157 | | |
149 | 158 | | |
150 | 159 | | |
151 | | - | |
| 160 | + | |
152 | 161 | | |
153 | 162 | | |
154 | | - | |
155 | | - | |
| 163 | + | |
| 164 | + | |
156 | 165 | | |
157 | | - | |
| 166 | + | |
158 | 167 | | |
159 | 168 | | |
160 | 169 | | |
161 | 170 | | |
162 | | - | |
| 171 | + | |
163 | 172 | | |
164 | | - | |
| 173 | + | |
165 | 174 | | |
166 | 175 | | |
167 | 176 | | |
| |||
193 | 202 | | |
194 | 203 | | |
195 | 204 | | |
196 | | - | |
| 205 | + | |
197 | 206 | | |
198 | 207 | | |
199 | 208 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
31 | 60 | | |
32 | 61 | | |
33 | 62 | | |
| |||
44 | 73 | | |
45 | 74 | | |
46 | 75 | | |
47 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
48 | 80 | | |
49 | 81 | | |
50 | 82 | | |
51 | | - | |
| 83 | + | |
52 | 84 | | |
53 | 85 | | |
54 | 86 | | |
55 | | - | |
56 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
57 | 98 | | |
58 | 99 | | |
59 | 100 | | |
60 | 101 | | |
61 | 102 | | |
62 | | - | |
| 103 | + | |
63 | 104 | | |
64 | 105 | | |
65 | 106 | | |
66 | 107 | | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
67 | 125 | | |
68 | 126 | | |
69 | 127 | | |
| |||
0 commit comments