Add test to confirm BCFIPS is working correctly

Author: rpanackal

cloudplatform/connectivity-apache-httpclient4/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/FipsProviderTest.java

@@ -1,9 +1,12 @@
 package com.sap.cloud.sdk.cloudplatform.connectivity;
 
 import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import java.io.FileReader;
 import java.security.KeyStore;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
 import java.security.Security;
 
 import org.bouncycastle.crypto.CryptoServicesRegistrar;
@@ -16,11 +19,12 @@
 import lombok.SneakyThrows;
 
 /**
- * Regression guard for the P1 fix: asserts that {@code KeyStoreReader.createKeyStore()} produces a PKCS12 keystore.
- * Run with {@code mvn test -P fips-approved}.
+ * Regression guard for the P1 fix: asserts that {@code KeyStoreReader.createKeyStore()} produces a PKCS12 keystore. Run
+ * with {@code mvn test -P fips-approved}.
  */
-@Tag("fips-approved")
-class FipsProviderTest {
+@Tag( "fips-approved" )
+class FipsProviderTest
+{
     private static final String RES = "src/test/resources/ClientCertificateAuthenticationLocalTest";
     private static final String CRT_PATH = RES + "/client-cert.crt";
     private static final String KEY_PATH = RES + "/client-cert.key";
@@ -34,22 +38,34 @@ static void removeBouncyCastleFips()
     }
 
     @BeforeAll
-    static void registerBouncyCastleFips() {
-        Security.insertProviderAt(new BouncyCastleFipsProvider("C:DEFRND[SHA256];ENABLE{ALL}"), 1);
+    static void registerBouncyCastleFips()
+    {
+        Security.insertProviderAt(new BouncyCastleFipsProvider(), 1);
 
-        assertThat(Security.getProvider("BCFIPS")).describedAs("BC FIPS provider must be registered as a JCA provider").isNotNull();
+        assertThat(Security.getProvider("BCFIPS"))
+            .describedAs("BC FIPS provider must be registered as a JCA provider")
+            .isNotNull();
 
-        assertThat(CryptoServicesRegistrar.isInApprovedOnlyMode()).describedAs("BC FIPS must be in approved-only mode. " + "Ensure -Dorg.bouncycastle.fips.approved_only=true is set (done by the fips-approved Maven profile).").isTrue();
+        assertThat(CryptoServicesRegistrar.isInApprovedOnlyMode())
+            .describedAs("BC FIPS must be in approved-only mode. ")
+            .isTrue();
     }
 
-    /**
-     * Regression guard for the P1 fix: verifies that {@code KeyStoreReader.createKeyStore()} produces a PKCS12
-     */
     @Test
     @SneakyThrows
-    void keystoreTypeIsP12() {
-        final KeyStore keyStore = KeyStoreReader.createKeyStore(ALIAS, EMPTY_PASSWORD, new FileReader(CRT_PATH), new FileReader(KEY_PATH));
+    void keystoreTypeIsP12()
+    {
+        final KeyStore keyStore =
+            KeyStoreReader.createKeyStore(ALIAS, EMPTY_PASSWORD, new FileReader(CRT_PATH), new FileReader(KEY_PATH));
 
         assertThat(keyStore.getType()).isEqualTo("PKCS12");
     }
-}
+
+    @Test
+    void md5IsRejectedInApprovedOnlyMode()
+    {
+        assertThatThrownBy(() -> MessageDigest.getInstance("MD5", "BCFIPS"))
+            .isInstanceOf(NoSuchAlgorithmException.class);
+
+    }
+}