Skip to content

Commit 6c61d23

Browse files
committed
Warn about the Recipient validation.
1 parent 6788e86 commit 6c61d23

3 files changed

Lines changed: 9 additions & 1 deletion

File tree

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Ruby SAML [![Build Status](https://secure.travis-ci.org/onelogin/ruby-saml.svg)](http://travis-ci.org/onelogin/ruby-saml) [![Coverage Status](https://coveralls.io/repos/onelogin/ruby-saml/badge.svg?branch=master%0A)](https://coveralls.io/r/onelogin/ruby-saml?branch=master%0A) [![Gem Version](https://badge.fury.io/rb/ruby-saml.svg)](http://badge.fury.io/rb/ruby-saml)
22

3+
## Updating from 1.4.2 to 1.4.3
4+
5+
Version `1.4.3` introduces Recipient validation of SubjectConfirmation elements.
6+
The 'Recipient' value is compared with the settings.assertion_consumer_service_url
7+
value.
8+
If you want to skip that validation, add the :skip_recipient_check option to the
9+
initialize method of the Response object.
10+
311
## Updating from 1.3.x to 1.4.X
412

513
Version `1.4.0` is a recommended update for all Ruby SAML users as it includes security improvements.

changelog.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
* Improve binding detection on idp metadata parser
77
* [#373](https://github.com/onelogin/ruby-saml/pull/373) Allow metadata to be retrieved from source containing data for multiple entities
88
* Be able to register future SP x509cert on the settings and publish it on SP metadata
9-
* Be able to register future SP x509cert on the settings and publish it on SP metadata.
109
* Be able to register more than 1 Identity Provider x509cert, linked with an specific use (signing or encryption.
1110
* Improve regex to detect base64 encoded messages
1211
* Fix binding configuration example in README.md

lib/onelogin/ruby-saml/response.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ class Response < SamlMessage
3737
# with the :skip_conditions, or allow a clock_drift when checking dates with :allowed_clock_drift
3838
# or :matches_request_id that will validate that the response matches the ID of the request,
3939
# or skip the subject confirmation validation with the :skip_subject_confirmation option
40+
# or skip the recipient validation of the subject confirmation element with :skip_recipient_check option
4041
def initialize(response, options = {})
4142
raise ArgumentError.new("Response cannot be nil") if response.nil?
4243

0 commit comments

Comments
 (0)