Skip to content

Commit 6962bf5

Browse files
committed
Pending utc changes
1 parent 9577d86 commit 6962bf5

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/onelogin/ruby-saml/idp_metadata_parser.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def parse(idp_metadata, options = {})
116116
unless parsed_metadata[:cache_duration].nil?
117117
cache_valid_until_timestamp = OneLogin::RubySaml::Utils.parse_duration(parsed_metadata[:cache_duration])
118118
if parsed_metadata[:valid_until].nil? || cache_valid_until_timestamp < Time.parse(parsed_metadata[:valid_until], Time.now.utc).to_i
119-
parsed_metadata[:valid_until] = Time.at(cache_valid_until_timestamp).strftime("%Y-%m-%dT%H:%M:%SZ")
119+
parsed_metadata[:valid_until] = Time.at(cache_valid_until_timestamp).utc.strftime("%Y-%m-%dT%H:%M:%SZ")
120120
end
121121
end
122122
# Remove the cache_duration because on the settings

test/idp_metadata_parser_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -338,19 +338,19 @@ def initialize; end
338338
it "if no ValidUntil but CacheDuration return CacheDuration converted in ValidUntil" do
339339
Timecop.freeze(Time.parse("2020-01-02T10:02:33Z", Time.now.utc)) do
340340
settings = @idp_metadata_parser.parse(idp_metadata_descriptor5)
341-
assert_equal '2020-01-03T11:02:33Z', settings.valid_until
341+
assert_equal '2020-01-03T10:02:33Z', settings.valid_until
342342
end
343343
end
344344

345345
it "if ValidUntil and CacheDuration return the sooner timestamp" do
346346
Timecop.freeze(Time.parse("2020-01-01T10:12:55Z", Time.now.utc)) do
347347
settings = @idp_metadata_parser.parse(idp_metadata_descriptor6)
348-
assert_equal '2020-01-03T11:12:55Z', settings.valid_until
348+
assert_equal '2020-01-03T10:12:55Z', settings.valid_until
349349
end
350350

351351
Timecop.freeze(Time.parse("2020-01-01T10:12:55Z", Time.now.utc)) do
352352
settings = @idp_metadata_parser.parse(idp_metadata_descriptor6)
353-
assert_equal '2020-01-03T11:12:55Z', settings.valid_until
353+
assert_equal '2020-01-03T10:12:55Z', settings.valid_until
354354
end
355355

356356
Timecop.freeze(Time.parse("2020-01-03T10:12:55Z", Time.now.utc)) do

0 commit comments

Comments
 (0)