Skip to content

Commit 2e0bb81

Browse files
committed
Separate file for SloLogutreq.#name_id_format test
Use a separate XML file for SloLogoutrequest#name_id_format tests. Apparently there are various representations of the file that I modified that are all supposed to be equivalent.
1 parent f91308d commit 2e0bb81

4 files changed

Lines changed: 16 additions & 1 deletion

File tree

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<samlp:LogoutRequest Version='2.0' ID='_c0348950-935b-0131-1060-782bcb56fcaa' xmlns:samlp='urn:oasis:names:tc:SAML:2.0:protocol' IssueInstant='2014-03-21T19:20:13'>
22
<saml:Issuer xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion'>https://app.onelogin.com/saml/metadata/SOMEACCOUNT</saml:Issuer>
3-
<saml:NameID xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion' Format='urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress'>someone@example.org</saml:NameID>
3+
<saml:NameID xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion'>someone@example.org</saml:NameID>
44
</samlp:LogoutRequest>
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<samlp:LogoutRequest Version='2.0' ID='_c0348950-935b-0131-1060-782bcb56fcaa' xmlns:samlp='urn:oasis:names:tc:SAML:2.0:protocol' IssueInstant='2014-03-21T19:20:13'>
2+
<saml:Issuer xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion'>https://app.onelogin.com/saml/metadata/SOMEACCOUNT</saml:Issuer>
3+
<saml:NameID xmlns:saml='urn:oasis:names:tc:SAML:2.0:assertion' Format='urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress'>someone@example.org</saml:NameID>
4+
</samlp:LogoutRequest>

test/slo_logoutrequest_test.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ class RubySamlTest < Minitest::Test
9292
end
9393

9494
describe "#nameid_format" do
95+
let(:logout_request) { OneLogin::RubySaml::SloLogoutrequest.new(logout_request_document_with_name_id_format) }
96+
9597
it "extract the format attribute of the name id element" do
9698
assert_equal "urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress", logout_request.nameid_format
9799
end

test/test_helper.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,15 @@ def logout_request_document
183183
@logout_request_document
184184
end
185185

186+
def logout_request_document_with_name_id_format
187+
unless @logout_request_document_with_name_id_format
188+
xml = read_logout_request("slo_request_with_name_id_format.xml")
189+
deflated = Zlib::Deflate.deflate(xml, 9)[2..-5]
190+
@logout_request_document_with_name_id_format = Base64.encode64(deflated)
191+
end
192+
@logout_request_document_with_name_id_format
193+
end
194+
186195
def logout_request_xml_with_session_index
187196
@logout_request_xml_with_session_index ||= File.read(File.join(File.dirname(__FILE__), 'logout_requests', 'slo_request_with_session_index.xml'))
188197
end

0 commit comments

Comments
 (0)