Skip to content

Commit 1333aac

Browse files
committed
fix failure when verifying validity of idp_cert_multi certificates
1 parent 6ca9a93 commit 1333aac

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

lib/onelogin/ruby-saml/idp_metadata_parser.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,8 @@ def merge_certificates_into(parsed_metadata)
335335
)
336336
end
337337
else
338-
parsed_metadata[:idp_cert_multi] = certificates
338+
# symbolize keys of certificates and pass it on
339+
parsed_metadata[:idp_cert_multi] = Hash[certificates.map { |k, v| [k.to_sym, v] }]
339340
end
340341
end
341342

test/idp_metadata_parser_test.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,10 @@ def initialize; end
202202
assert_nil settings.idp_cert_fingerprint
203203
assert_nil settings.idp_cert
204204
assert_equal 2, settings.idp_cert_multi.size
205-
assert settings.idp_cert_multi.key?("signing")
206-
assert_equal 2, settings.idp_cert_multi["signing"].size
207-
assert settings.idp_cert_multi.key?("encryption")
208-
assert_equal 1, settings.idp_cert_multi["encryption"].size
205+
assert settings.idp_cert_multi.key?(:signing)
206+
assert_equal 2, settings.idp_cert_multi[:signing].size
207+
assert settings.idp_cert_multi.key?(:encryption)
208+
assert_equal 1, settings.idp_cert_multi[:encryption].size
209209
end
210210
end
211211

0 commit comments

Comments
 (0)