Skip to content

Commit a760361

Browse files
committed
Merge pull request #23 from kipparker/master
Fixes Windows specific Unix date formatting bug
2 parents bb695a6 + cb72ae9 commit a760361

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

src/onelogin/saml2/metadata.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
1010
"""
1111

12-
from time import gmtime, strftime
12+
from time import gmtime, strftime, time
1313
from datetime import datetime
1414

1515
from onelogin.saml2 import compat
@@ -61,7 +61,7 @@ def builder(sp, authnsign=False, wsign=False, valid_until=None, cache_duration=N
6161
:type organization: dict
6262
"""
6363
if valid_until is None:
64-
valid_until = int(datetime.now().strftime("%s")) + OneLogin_Saml2_Metadata.TIME_VALID
64+
valid_until = int(time()) + OneLogin_Saml2_Metadata.TIME_VALID
6565
if not isinstance(valid_until, basestring):
6666
if isinstance(valid_until, datetime):
6767
valid_until_time = valid_until.timetuple()

src/onelogin/saml2/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Setting class of OneLogin's Python Toolkit.
99
1010
"""
11-
from datetime import datetime
11+
from time import time
1212
import re
1313
from os.path import dirname, exists, join, sep
1414

@@ -720,7 +720,7 @@ def validate_metadata(self, xml):
720720
if valid_until:
721721
valid_until = OneLogin_Saml2_Utils.parse_SAML_to_time(valid_until)
722722
expire_time = OneLogin_Saml2_Utils.get_expire_time(cache_duration, valid_until)
723-
if expire_time is not None and int(datetime.now().strftime('%s')) > int(expire_time):
723+
if expire_time is not None and int(time()) > int(expire_time):
724724
errors.append('expired_xml')
725725

726726
# TODO: Validate Sign

0 commit comments

Comments
 (0)