Fix Test

Author: pitbulk

tests/src/OneLogin/saml2_tests/auth_test.py

@@ -986,7 +986,7 @@ def testIsInValidLogoutResponseSign(self):
 
         auth = OneLogin_Saml2_Auth(request_data, old_settings=settings_2)
         auth.process_slo()
-        self.assertIn('In order to validate the sign on the SAMLResponse, the x509cert of the IdP is required', auth.get_errors())
+        self.assertIn('Signature validation failed. Logout Response rejected', auth.get_errors())
 
     def testIsValidLogoutRequestSign(self):
         """
@@ -1074,4 +1074,4 @@ def testIsValidLogoutRequestSign(self):
         settings_2 = OneLogin_Saml2_Settings(settings_info)
         auth = OneLogin_Saml2_Auth(request_data, old_settings=settings_2)
         auth.process_slo()
-        self.assertIn('In order to validate the sign on the SAMLRequest, the x509cert of the IdP is required', auth.get_errors())
+        self.assertIn('Signature validation failed. Logout Request rejected', auth.get_errors())

tests/src/OneLogin/saml2_tests/settings_test.py

@@ -404,12 +404,23 @@ def testGetSPMetadataSigned(self):
         settings_info = self.loadSettingsJSON()
         if 'security' not in settings_info:
             settings_info['security'] = {}
+
+        settings_info['security']['signMetadata'] = {}
+
+        try:
+            OneLogin_Saml2_Settings(settings_info)
+            self.assertTrue(False)
+        except Exception as e:
+            self.assertIn('sp_signMetadata_invalid', str(e))
+
+        # Default cert/key
         settings_info['security']['signMetadata'] = True
         self.generateAndCheckMetadata(settings_info)
 
         # Now try again with SP keys set directly in settings and not from files:
         del settings_info['custom_base_path']
-        self.generateAndCheckMetadata(settings_info)
+        with self.assertRaises(OneLogin_Saml2_Error):
+            OneLogin_Saml2_Settings(settings_info).get_sp_metadata()
 
         # Now the keys should not be found, so metadata generation won't work:
         del settings_info['sp']['x509cert']