review comments

Author: Jimmy John

setup.py

@@ -9,7 +9,7 @@
 
 setup(
     name='python-saml',
-    version='2.2.0',
+    version='2.1.6',
     description='Onelogin Python Toolkit. Add SAML support to your Python software using this library',
     classifiers=[
         'Development Status :: 4 - Beta',

src/onelogin/saml2/metadata.py

@@ -182,7 +182,7 @@ def builder(sp, authnsign=False, wsign=False, valid_until=None, cache_duration=N
             str_contacts = '\n'.join(contacts_info)
 
         metadata = """<?xml version="1.0"?>
-<md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion"
+<md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata" %(saml_namespace)s
                      %(valid)s
                      %(cache)s
                      entityID="%(entity_id)s">
@@ -207,6 +207,7 @@ def builder(sp, authnsign=False, wsign=False, valid_until=None, cache_duration=N
                 'sls': sls,
                 'organization': str_organization,
                 'contacts': str_contacts,
+                'saml_namespace': 'xmlns:saml="urn:oasis:names:tc:SAML:2.0:assertion"' if attr_consuming_service else ''
             }
 
         # i'm not sure why the above xml was build by hand. Building via lxml is way easier,