Setup the environment. Connect with travis and coverall. Fix pep8

Author: pitbulk

.coveralls.yml

@@ -12,11 +12,12 @@ __pycache_
 /.installed.cfg
 /develop-eggs
 /*.eg
-/*.egg-info
+*.egg-info
 /eggs
 /build
 /dist
 /venv
+.coverage
 
 *.key
 *.crt

.gitignore

@@ -0,0 +1,18 @@
+language: python
+python:
+  - '2.6'
+  - '2.7'
+
+before_install:
+  - 'travis_retry sudo apt-get install python-dev libxml2-dev libxmlsec1-dev'
+
+install:
+  - 'travis_retry pip install -e ".[test]" --use-mirrors'
+
+script: 
+  - 'coverage run --source=src/onelogin/saml2 --rcfile=tests/coverage.rc setup.py test'
+  - 'coverage report -m --rcfile=tests/coverage.rc'
+  - 'pep8 tests/src/OneLogin/saml2_tests/*.py demo-flask/*.py demo-django/*.py src/onelogin/saml2/*.py --config=tests/pep8.rc'
+  - 'pyflakes src/onelogin/saml2 demo-django demo-flask tests/src/OneLogin/saml2_tests'
+
+after_success: 'coveralls --rcfile=.coveralls.yml'

.travis.yml

@@ -4,7 +4,7 @@
 # Copyright (c) 2014, OneLogin, Inc.
 # All rights reserved.
 
-from setuptools import setup, find_packages
+from setuptools import setup
 
 setup(
     name='python-saml',
@@ -21,27 +21,24 @@
     author_email='support@onelogin.com',
     license='BSD',
     url='https://github.com/onelogin/python-saml',
-    packages = ['onelogin/saml2'],
+    packages=['onelogin/saml2'],
     package_dir={
         '': 'src',
-    },    
+    },
     test_suite='tests',
     install_requires=[
         'M2Crypto==0.22.3',
         'dm.xmlsec.binding==1.3.1',
         'isodate==0.5.0',
         'defusedxml==0.4.1',
-    ]
+    ],
     extras_require={
         'test': (
-            # Test runner.
-            'pytest',
-
-            # Ensure PEP8 conformance.
-            'pytest-pep8',
-
-            # Ensure test coverage.
-            'pytest-cov',
-        )
-    }
+            'coverage==3.7.1',
+            'pylint==1.3.1',
+            'pep8==1.5.7',
+            'pyflakes==0.8.1',
+            'coveralls==0.4.4',
+        ),
+    },
 )

setup.py

@@ -118,8 +118,8 @@ def is_valid(self, request_data, request_id=None):
                     if not destination.startswith(current_url):
                         # TODO: Review if following lines are required, since we can control the
                         # request_data
-                        #current_url_routed = OneLogin_Saml2_Utils.get_self_routed_url_no_query(request_data)
-                        #if not destination.startswith(current_url_routed):
+                        #  current_url_routed = OneLogin_Saml2_Utils.get_self_routed_url_no_query(request_data)
+                        #  if not destination.startswith(current_url_routed):
                         raise Exception('The response was received at %s instead of %s' % (current_url, destination))
 
                 # Checks audience
@@ -352,7 +352,7 @@ def validate_timestamps(self):
         :rtype: bool
         """
         conditions_nodes = self.__query_assertion('/saml:Conditions')
-        
+
         for conditions_node in conditions_nodes:
             nb_attr = conditions_node.get('NotBefore')
             nooa_attr = conditions_node.get('NotOnOrAfter')

src/onelogin/saml2/response.py

@@ -580,7 +580,7 @@ def validate_metadata(self, xml):
         else:
             dom = res
             element = dom.documentElement
-            if not element.tagName in 'md:EntityDescriptor':
+            if element.tagName not in 'md:EntityDescriptor':
                 errors.append('noEntityDescriptor_xml')
             else:
                 if len(element.getElementsByTagName('md:SPSSODescriptor')) != 1:

src/onelogin/saml2/settings.py

@@ -593,7 +593,7 @@ def generate_name_id(value, sp_nq, sp_format, cert=None, debug=False):
             enc_data = EncData(xmlsec.TransformAes128Cbc, type=xmlsec.TypeEncElement)
             enc_data.ensureCipherValue()
             key_info = enc_data.ensureKeyInfo()
-            #enc_key = key_info.addEncryptedKey(xmlsec.TransformRsaPkcs1)
+            # enc_key = key_info.addEncryptedKey(xmlsec.TransformRsaPkcs1)
             enc_key = key_info.addEncryptedKey(xmlsec.TransformRsaOaep)
             enc_key.ensureCipherValue()
 

src/onelogin/saml2/utils.py

@@ -0,0 +1,30 @@
+[run]
+branch = True
+
+omit = 
+
+[paths]
+source = src/onelogin/saml2
+
+[report]
+# Regexes for lines to exclude from consideration
+exclude_lines =
+
+
+    # Have to re-enable the standard pragma
+    pragma: no cover
+
+    # Don't complain about missing debug-only code:
+    def __repr__
+    if self\.debug
+    if debug
+
+    # Don't complain if tests don't hit defensive assertion code:
+    raise AssertionError
+    raise NotImplementedError
+
+    # Don't complain if non-runnable code isn't run:
+    if 0:
+    if __name__ == .__main__.:
+
+ignore_errors = True

tests/coverage.rc

@@ -0,0 +1,3 @@
+[pep8]
+ignore = E501
+max-line-length = 160

tests/pep8.rc

@@ -0,0 +1,73 @@
+[MASTER]
+profile=no
+persistent=yes
+ignore=
+cache-size=500
+
+[REPORTS]
+output-format=text
+files-output=no
+reports=yes
+
+[BASIC]
+no-docstring-rgx=__.*__|_.*
+class-rgx=[A-Z_][a-zA-Z0-9_]+$
+function-rgx=[a-zA_][a-zA-Z0-9_]{2,70}$
+method-rgx=[a-z_][a-zA-Z0-9_]{2,70}$
+const-rgx=(([A-Z_][A-Z0-9_]*)|([a-z_][a-z0-9_]*)|(__.*__)|register|urlpatterns)$
+good-names=_,i,j,k,e,qs,pk,setUp,tearDown,el,ns,fd,js
+
+[TYPECHECK]
+
+# Tells whether missing members accessed in mixin class should be ignored. A
+# mixin class is detected if its name ends with "mixin" (case insensitive).
+ignore-mixin-members=yes
+
+# List of module names for which member attributes should not be checked
+# (useful for modules/projects where namespaces are manipulated during runtime
+# and thus extisting member attributes cannot be deduced by static analysis
+ignored-modules=
+
+# List of classes names for which member attributes should not be checked
+# (useful for classes with attributes dynamically set).
+ignored-classes=SQLObject,WSGIRequest
+
+# When zope mode is activated, add a predefined set of Zope acquired attributes
+# to generated-members.
+zope=no
+
+# List of members which are set dynamically and missed by pylint inference
+# system, and so shouldn't trigger E0201 when accessed.
+generated-members=objects,DoesNotExist,id,pk,_meta,base_fields,context,views,save
+
+# List of method names used to declare (i.e. assign) instance attributes
+defining-attr-methods=__init__,__new__,setUp
+
+[VARIABLES]
+init-import=no
+dummy-variables-rgx=_|dummy
+
+[SIMILARITIES]
+min-similarity-lines=6
+ignore-comments=yes
+ignore-docstrings=yes
+[MISCELLANEOUS]
+notes=FIXME,XXX,TODO
+
+[FORMAT]
+max-line-length=160
+max-module-lines=500
+indent-string='    '
+indent-after-paren=4
+
+[DESIGN]
+max-args=10
+max-locals=15
+max-returns=6
+max-branchs=12
+max-statements=50
+max-parents=10
+max-attributes=10
+min-public-methods=0
+max-public-methods=100
+