Merge pull request #22 from mtyaka/default-parser

Don't use default global XML parser to parse response.

Author: pitbulk

onelogin/saml/Response.py

@@ -83,7 +83,7 @@ def __init__(self, request_data, response, signature, _base64=None, _etree=None,
 
         self._request_data = request_data
         decoded_response = _base64.b64decode(response)
-        self._document = _etree.fromstring(decoded_response)
+        self._document = _etree.fromstring(decoded_response, parser=_etree.XMLParser())
         self._signature = signature
         self._issuer = issuer
 

onelogin/saml/test/TestResponse.py

@@ -81,8 +81,12 @@ def test__init__(self):
 
         fake_etree = fudge.Fake('etree')
         fake_etree.remember_order()
+        xmlparser = fake_etree.expects('XMLParser')
+        xmlparser.with_arg_count(0)
+        fake_xmlparser = fudge.Fake('etree.XMLParser')
+        xmlparser.returns(fake_xmlparser)
         from_string = fake_etree.expects('fromstring')
-        from_string.with_args('foo decoded response')
+        from_string.with_args('foo decoded response', parser=fake_xmlparser)
         from_string.returns('foo document')
 
         res = Response(