Skip to content

Commit d08dd47

Browse files
committed
Forgot to modify LogoutResponse code
1 parent 123e939 commit d08dd47

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

src/onelogin/saml2/logout_response.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from base64 import b64encode, b64decode
1313
from defusedxml.lxml import fromstring
1414

15-
from urllib import quote_plus
1615
from xml.dom.minidom import Document
1716
from defusedxml.minidom import parseString
1817

@@ -120,10 +119,10 @@ def is_valid(self, request_data, request_id=None):
120119
else:
121120
sign_alg = get_data['SigAlg']
122121

123-
signed_query = 'SAMLResponse=%s' % quote_plus(get_data['SAMLResponse'])
122+
signed_query = 'SAMLResponse=%s' % OneLogin_Saml2_Utils.get_encoded_parameter(get_data, 'SAMLResponse')
124123
if 'RelayState' in get_data:
125-
signed_query = '%s&RelayState=%s' % (signed_query, quote_plus(get_data['RelayState']))
126-
signed_query = '%s&SigAlg=%s' % (signed_query, quote_plus(sign_alg))
124+
signed_query = '%s&RelayState=%s' % (signed_query, OneLogin_Saml2_Utils.get_encoded_parameter(get_data, 'RelayState'))
125+
signed_query = '%s&SigAlg=%s' % (signed_query, OneLogin_Saml2_Utils.get_encoded_parameter(get_data, 'SigAlg', OneLogin_Saml2_Constants.RSA_SHA1))
127126

128127
if 'x509cert' not in idp_data or idp_data['x509cert'] is None:
129128
raise Exception('In order to validate the sign on the Logout Response, the x509cert of the IdP is required')

0 commit comments

Comments
 (0)