Skip to content

Commit 808d76d

Browse files
committed
Improve comments and documentation
1 parent 8da9c5b commit 808d76d

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ not be used for anything other than exploring and testing.
7575
Creating and sending the AuthnRequest to the identity provider
7676
--------------------------------------------------------------
7777
The identification flow starts when a user requests a resource from the service
78-
provider which, in this case, is implemented in our example app. In our example,
78+
provider which, in this case, is implemented in our example app. In our example
7979
the user requests a resource by going to the root path of our app, i.e,::
8080

8181
http://localhost:7070/
@@ -117,7 +117,7 @@ Receiving and verifying the response
117117
------------------------------------
118118
The user will then be redirected to the OneLogin login page where they will
119119
enter their credentials in order to verify their identity. After OneLogin has
120-
verified their identity, it will redirect the user to the
120+
verified their identity it will redirect the user to the
121121
assertion_consumer_service_url--http://localhost:7070/example/saml/consume.
122122

123123
Our example app then verifies the SAML Response from OneLogin using the fingerprint

example.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ assertion_consumer_service_url =
1212
idp_sso_target_url =
1313
# The x.509 certificate fingerprint from OneLogin, found under Security->SAML,
1414
# as a file path. Only one of idp_cert_file and idp_cert_fingerprint will be
15-
# used by the example app, with idp_cert_file being having priority if both are
15+
# used by the example app, with idp_cert_file having priority if both are
1616
# defined.
1717
idp_cert_file =
1818
# The x.509 certificate fingerprint from OneLogin, found under Security->SAML,
1919
# as a string. Only one of idp_cert_file and idp_cert_fingerprint will be
20-
# used by the example app, with idp_cert_file being having priority if both are
20+
# used by the example app, with idp_cert_file having priority if both are
2121
# defined.
2222
idp_cert_fingerprint =

onelogin/saml/Response.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def _get_name_id(self):
8181

8282
name_id = property(
8383
fget=_get_name_id,
84-
doc="The identity provider to which the user belongs",
84+
doc="The value requested in the name_identifier_format, e.g., the user's email address",
8585
)
8686

8787
def is_valid(

0 commit comments

Comments
 (0)