Added some more tests

Author: pitbulk

README.md

@@ -320,9 +320,9 @@ In addition to the required settings data (idp, sp), there is extra information
 
         // In some environment you will need to set how long the published metadata of the Service Provider gonna be valid.
         // is possible to not set the 2 following parameters (or set to null) and default values will be set (2 days, 1 week)
-        // Provide the desire TimeStamp, for example 2015-06-26T20:00:00Z
+        // Provide the desired Timestamp, for example 2015-06-26T20:00:00Z
         'metadataValidUntil': null,
-        // Provide the desire Duration, for example PT518400S (6 days)
+        // Provide the desired duration, for example PT518400S (6 days)
         'metadataCacheDuration': null
     },
 

tests/src/OneLogin/saml2_tests/settings_test.py

@@ -371,9 +371,23 @@ def testGetSPMetadataSigned(self):
         settings_info = self.loadSettingsJSON()
         if 'security' not in settings_info:
             settings_info['security'] = {}
+
+        # Use custom cert/key
+        settings_info['security']['signMetadata'] = {
+            "keyFileName": "sp.key",
+            "certFileName": "sp.crt"
+        }
+        self.generateAndCheckMetadata(settings_info)
+
+        # Default cert/key
         settings_info['security']['signMetadata'] = True
         self.generateAndCheckMetadata(settings_info)
 
+        # Now try again with SP keys set directly from files that no exists:
+        settings_info['custom_base_path'] = '../path/not/exists/'
+        with self.assertRaises(OneLogin_Saml2_Error):
+            OneLogin_Saml2_Settings(settings_info).get_sp_metadata()
+
         # Now try again with SP keys set directly in settings and not from files:
         del settings_info['custom_base_path']
         # Now the keys should not be found, so metadata generation won't work:
@@ -384,6 +398,11 @@ def testGetSPMetadataSigned(self):
         settings_info['sp']['privateKey'] = self.file_contents(join(self.data_path, 'customPath', 'certs', 'sp.key'))
         self.generateAndCheckMetadata(settings_info)
 
+        # Now fails due no privateKey
+        del settings_info['sp']['privateKey']
+        with self.assertRaises(OneLogin_Saml2_Error):
+            OneLogin_Saml2_Settings(settings_info).get_sp_metadata()
+
     def generateAndCheckMetadata(self, settings):
         """
         Helper method: Given some settings, generate metadata and validate it