Let the setting object to avoid the IdP setting check. required if we want to publish SP SAML Metadata when the IdP data is still not provided. Close #74

Author: pitbulk

README.md

@@ -496,6 +496,12 @@ The get_sp_metadata will return the metadata signed or not based on the security
 
 Before the XML metadata is exposed, a check takes place to ensure that the info to be provided is valid.
 
+Instead of use the Auth object, you can directly use
+```
+saml_settings = OneLogin_Saml2_Settings(settings=None, custom_base_path=None, sp_validation_only=True)
+```
+to get the settings object and with the sp_validation_only=True parameter we will avoid the IdP Settings validation.
+
 ***Attribute Consumer Service(ACS)***
 
 This code handles the SAML response that the IdP forwards to the SP through the user's client.
@@ -787,6 +793,8 @@ Configuration of the OneLogin Python Toolkit
 
 * `__init__`  Initializes the settings: Sets the paths of the different folders and Loads settings info from settings file or array/object provided.
 * ***check_settings*** Checks the settings info.
+* ***check_idp_settings*** Checks the IdP settings info.
+* ***check_sp_settings*** Checks the SP settings info.
 * ***get_errors*** Returns an array with the errors, the array is empty when the settings is ok.
 * ***get_sp_metadata*** Gets the SP metadata. The XML representation.
 * ***validate_metadata*** Validates an XML SP Metadata.

demo-django/demo/views.py

@@ -6,6 +6,7 @@
 from django.template import RequestContext
 
 from onelogin.saml2.auth import OneLogin_Saml2_Auth
+from onelogin.saml2.settings import OneLogin_Saml2_Settings
 from onelogin.saml2.utils import OneLogin_Saml2_Utils
 
 
@@ -100,9 +101,10 @@ def attrs(request):
 
 
 def metadata(request):
-    req = prepare_django_request(request)
-    auth = init_saml_auth(req)
-    saml_settings = auth.get_settings()
+    # req = prepare_django_request(request)
+    # auth = init_saml_auth(req)
+    # saml_settings = auth.get_settings()
+    saml_settings = OneLogin_Saml2_Settings(settings=None, custom_base_path=settings.SAML_FOLDER, sp_validation_only=True)
     metadata = saml_settings.get_sp_metadata()
     errors = saml_settings.validate_metadata(metadata)
 

src/onelogin/saml2/settings.py

@@ -58,7 +58,7 @@ class OneLogin_Saml2_Settings(object):
 
     """
 
-    def __init__(self, settings=None, custom_base_path=None):
+    def __init__(self, settings=None, custom_base_path=None, sp_validation_only=False):
         """
         Initializes the settings:
         - Sets the paths of the different folders
@@ -70,6 +70,7 @@ def __init__(self, settings=None, custom_base_path=None):
         :param custom_base_path: Path where are stored the settings file and the cert folder
         :type custom_base_path: string
         """
+        self.__sp_validation_only = False
         self.__paths = {}
         self.__strict = False
         self.__debug = False
@@ -325,9 +326,10 @@ def check_settings(self, settings):
         if not isinstance(settings, dict) or len(settings) == 0:
             errors.append('invalid_syntax')
         else:
-            idp_erros = self.check_idp_settings(settings)
+            if not self.__sp_validation_only:
+                errors += self.check_idp_settings(settings)
             sp_errors = self.check_sp_settings(settings)
-            errors = idp_erros + sp_errors
+            errors += sp_errors
 
         return errors