From 16918b2564347d7e24a2838c8efc6acd5fa62e66 Mon Sep 17 00:00:00 2001 From: "@daniel-lxs" <57051444+daniel-lxs@users.noreply.github.com> Date: Tue, 27 Oct 2026 05:37:08 +0000 Subject: [PATCH] fix: name model search inputs using their picker context --- .../tasks/ModelSelect.search.client.test.tsx | 14 ++++++++++++++ apps/web/src/components/tasks/ModelSelect.tsx | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/apps/web/src/components/tasks/ModelSelect.search.client.test.tsx b/apps/web/src/components/tasks/ModelSelect.search.client.test.tsx index ddd9ac65a7..3527c3c0f4 100644 --- a/apps/web/src/components/tasks/ModelSelect.search.client.test.tsx +++ b/apps/web/src/components/tasks/ModelSelect.search.client.test.tsx @@ -35,6 +35,20 @@ beforeEach(() => { }); describe('ModelSelect real controls', () => { + it.each([undefined, 'Environment setup model', 'Coding model'])( + 'names the focused search input using the picker context %s', + async (ariaLabel) => { + render(); + fireEvent.click(screen.getByRole('combobox')); + + const input = await screen.findByRole('combobox', { + name: ariaLabel ?? 'Model', + }); + expect(input.tagName).toBe('INPUT'); + expect(input).toHaveFocus(); + }, + ); + it.each([undefined, 'Use default'])( 'keeps eight models on Select with empty option %s', (emptyOptionLabel) => { diff --git a/apps/web/src/components/tasks/ModelSelect.tsx b/apps/web/src/components/tasks/ModelSelect.tsx index b4bfc8b405..b503008747 100644 --- a/apps/web/src/components/tasks/ModelSelect.tsx +++ b/apps/web/src/components/tasks/ModelSelect.tsx @@ -117,7 +117,7 @@ export function ModelSelect({ align="start" className="w-(--radix-popover-trigger-width) p-0" > - + No models found.