From 7462bfcda14c887c0ebefbf98d8aaaffa5d5cb69 Mon Sep 17 00:00:00 2001
From: Bartok9 <259807879+Bartok9@users.noreply.github.com>
Date: Wed, 12 Aug 2026 13:25:00 -0400
Subject: [PATCH] fix(agents): reject empty agents list in runner helpers

AgentRunner and run_agents/wait_for_shutdown previously accepted [] and
would hang on wait or no-op silently. Require a non-empty agents list.

Signed-off-by: Bartok9 <danielrpike9@gmail.com>
---
 tests/agents/test_agent_runner_empty.py | 30 +++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 tests/agents/test_agent_runner_empty.py

diff --git a/tests/agents/test_agent_runner_empty.py b/tests/agents/test_agent_runner_empty.py
new file mode 100644
index 000000000..4dc06015e
--- /dev/null
+++ b/tests/agents/test_agent_runner_empty.py
@@ -0,0 +1,30 @@
+# Copyright (C) 2025 Robotec.AI
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+import pytest
+from rai.agents.runner import AgentRunner, run_agents, wait_for_shutdown
+
+
+@pytest.mark.parametrize(
+    "fn",
+    [
+        lambda: run_agents([]),
+        lambda: wait_for_shutdown([]),
+        lambda: AgentRunner([]),
+        lambda: run_agents(None),  # type: ignore[arg-type]
+    ],
+)
+def test_agent_helpers_reject_empty_agents(fn):
+    with pytest.raises(ValueError, match="agents must be a non-empty list"):
+        fn()