Merge pull request #719 from ajp427/fix-nodelist-check

IE8 Compat: Fix is NodeList check

Author: mattpodwysocki

dist/rx.all.compat.js

@@ -6648,6 +6648,20 @@
     };
   };
 
+  /**
+   * Returns true if `el` is a NodeList or StaticNodeList (IE8 querySelectorAll returns a StaticNodeList)
+   * @param {object} el
+   * @returns {boolean}
+   */
+  function isNodeList(el) {
+      if (window.StaticNodeList) {
+          // IE8 Specific
+          // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
+          return (el instanceof window.StaticNodeList || el instanceof NodeList);
+      } else {
+          return (Object.prototype.toString.call(el) == '[object NodeList]')
+      }
+  }
   function fixEvent(event) {
     var stopPropagation = function () {
       this.cancelBubble = true;
@@ -6730,7 +6744,7 @@
     var disposables = new CompositeDisposable();
 
     // Asume NodeList
-    if (Object.prototype.toString.call(el) === '[object NodeList]') {
+    if (isNodeList(el)) {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }

dist/rx.all.compat.map

@@ -379,6 +379,20 @@
     };
   };
 
+  /**
+   * Returns true if `el` is a NodeList or StaticNodeList (IE8 querySelectorAll returns a StaticNodeList)
+   * @param {object} el
+   * @returns {boolean}
+   */
+  function isNodeList(el) {
+      if (window.StaticNodeList) {
+          // IE8 Specific
+          // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
+          return (el instanceof window.StaticNodeList || el instanceof NodeList);
+      } else {
+          return (Object.prototype.toString.call(el) == '[object NodeList]')
+      }
+  }
   function fixEvent(event) {
     var stopPropagation = function () {
       this.cancelBubble = true;
@@ -461,7 +475,7 @@
     var disposables = new CompositeDisposable();
 
     // Asume NodeList
-    if (Object.prototype.toString.call(el) === '[object NodeList]') {
+    if (isNodeList(el)) {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }