Fixing Issue #694

Author: mattpodwysocki

dist/rx.all.compat.js

@@ -6653,13 +6653,13 @@
    * @returns {boolean}
    */
   function isNodeList(el) {
-      if (window.StaticNodeList) {
-          // IE8 Specific
-          // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
-          return (el instanceof window.StaticNodeList || el instanceof NodeList);
-      } else {
-          return (Object.prototype.toString.call(el) == '[object NodeList]')
-      }
+    if (window.StaticNodeList) {
+      // IE8 Specific
+      // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
+      return (el instanceof window.StaticNodeList || el instanceof NodeList);
+    } else {
+      return (Object.prototype.toString.call(el) == '[object NodeList]')
+    }
   }
   function fixEvent(event) {
     var stopPropagation = function () {
@@ -6743,7 +6743,7 @@
     var disposables = new CompositeDisposable();
 
     // Asume NodeList
-    if (isNodeList(el)) {
+    if (isNodeList(el) || Object.prototype.toString.call(el) === '[object HTMLCollection]') {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }

dist/rx.all.compat.map

@@ -6515,8 +6515,9 @@
   function createEventListener (el, eventName, handler) {
     var disposables = new CompositeDisposable();
 
-    // Asume NodeList
-    if (Object.prototype.toString.call(el) === '[object NodeList]') {
+    // Asume NodeList or HTMLCollection
+    var toStr = Object.prototype.toString;
+    if (toStr.call(el) === '[object NodeList]' || toStr.call(el) === '[object HTMLCollection]') {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }

dist/rx.all.compat.min.js

@@ -385,13 +385,13 @@
    * @returns {boolean}
    */
   function isNodeList(el) {
-      if (window.StaticNodeList) {
-          // IE8 Specific
-          // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
-          return (el instanceof window.StaticNodeList || el instanceof NodeList);
-      } else {
-          return (Object.prototype.toString.call(el) == '[object NodeList]')
-      }
+    if (window.StaticNodeList) {
+      // IE8 Specific
+      // instanceof is slower than Object#toString, but Object#toString will not work as intended in IE8
+      return (el instanceof window.StaticNodeList || el instanceof NodeList);
+    } else {
+      return (Object.prototype.toString.call(el) == '[object NodeList]')
+    }
   }
   function fixEvent(event) {
     var stopPropagation = function () {
@@ -475,7 +475,7 @@
     var disposables = new CompositeDisposable();
 
     // Asume NodeList
-    if (isNodeList(el)) {
+    if (isNodeList(el) || Object.prototype.toString.call(el) === '[object HTMLCollection]') {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }

dist/rx.all.js

@@ -392,8 +392,9 @@
   function createEventListener (el, eventName, handler) {
     var disposables = new CompositeDisposable();
 
-    // Asume NodeList
-    if (Object.prototype.toString.call(el) === '[object NodeList]') {
+    // Asume NodeList or HTMLCollection
+    var toStr = Object.prototype.toString;
+    if (toStr.call(el) === '[object NodeList]' || toStr.call(el) === '[object HTMLCollection]') {
       for (var i = 0, len = el.length; i < len; i++) {
         disposables.add(createEventListener(el.item(i), eventName, handler));
       }