Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Commit 3342842

Browse files
Sorting out debounce/throttle/withSelector methods.
- fixes for rx-time.js debounce/throttle methods definitions (rx.time.d.ts and rx.time-lite.d.ts) - throttleWithSelector JSDoc deprecated comment added - throttleWithSelector now uses direct call instead of prototype.apply
1 parent 018d570 commit 3342842

3 files changed

Lines changed: 20 additions & 2 deletions

File tree

src/core/linq/observable/debouncewithselector.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,10 @@
4848
}, source);
4949
};
5050

51-
observableProto.throttleWithSelector = function () {
51+
/**
52+
* @deprecated use #debounceWithSelector instead.
53+
*/
54+
observableProto.throttleWithSelector = function (durationSelector) {
5255
//deprecate('throttleWithSelector', 'debounceWithSelector');
53-
return this.debounceWithSelector.apply(this, arguments);
56+
return this.debounceWithSelector(durationSelector);
5457
};

ts/rx.time-lite.d.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,21 @@ declare module Rx {
1919
export interface Observable<T> {
2020
delay(dueTime: Date, scheduler?: IScheduler): Observable<T>;
2121
delay(dueTime: number, scheduler?: IScheduler): Observable<T>;
22+
23+
debounce(dueTime: number, scheduler?: IScheduler): Observable<T>;
24+
throttleWithTimeout(dueTime: number, scheduler?: IScheduler): Observable<T>;
25+
/**
26+
* @deprecated use #debounce or #throttleWithTimeout instead.
27+
*/
2228
throttle(dueTime: number, scheduler?: IScheduler): Observable<T>;
29+
2330
timeInterval(scheduler?: IScheduler): Observable<TimeInterval<T>>;
31+
2432
timestamp(scheduler?: IScheduler): Observable<Timestamp<T>>;
33+
2534
sample(interval: number, scheduler?: IScheduler): Observable<T>;
2635
sample<TSample>(sampler: Observable<TSample>, scheduler?: IScheduler): Observable<T>;
36+
2737
timeout(dueTime: Date, other?: Observable<T>, scheduler?: IScheduler): Observable<T>;
2838
timeout(dueTime: number, other?: Observable<T>, scheduler?: IScheduler): Observable<T>;
2939
}

ts/rx.time.d.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ declare module Rx {
1313
delayWithSelector(subscriptionDelay: number, delayDurationSelector: (item: T) => number): Observable<T>;
1414

1515
timeoutWithSelector<TTimeout>(firstTimeout: Observable<TTimeout>, timeoutdurationSelector?: (item: T) => Observable<TTimeout>, other?: Observable<T>): Observable<T>;
16+
1617
debounceWithSelector<TTimeout>(debounceDurationSelector: (item: T) => Observable<TTimeout>): Observable<T>;
18+
/**
19+
* @deprecated use #debounceWithSelector instead.
20+
*/
21+
throttleWithSelector<TTimeout>(debounceDurationSelector: (item: T) => Observable<TTimeout>): Observable<T>;
1722

1823
skipLastWithTime(duration: number, scheduler?: IScheduler): Observable<T>;
1924
takeLastWithTime(duration: number, timerScheduler?: IScheduler, loopScheduler?: IScheduler): Observable<T>;

0 commit comments

Comments
 (0)