From 6c32c8cf3beca8aa9b774672a650ff007f7dee0f Mon Sep 17 00:00:00 2001 From: Bhanu Kiran Atturu Date: Tue, 22 Sep 2026 13:39:41 -0700 Subject: [PATCH 1/2] [NO-JIRA] docs(agfhc): fix recipe matrix gaps for AGFHC 1.34.2 (#1679) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Restore acf_lvl1–acf_lvl4 columns dropped during multi-GPU matrix rewrite - Fix MI350P row: all_lvl5, single_pass, hbm_lvl5, acf_lvl* present in shipped image (amdpsdo/test-runner:agfhc-v1.5.2-12, AGFHC 1.34.2) - Add MI350P to partition profiles table (SPX/NPS1, 1 and 4 GPUs) - Add acf_lvl1 to agfhc_recipes in amdgpu-features.json for all AGFHC-enabled GPUs (MI300X, MI308X, MI325X, MI350P, MI350X, MI355X) - Add acf_lvl1 pytest parametrize entry in test_manual_job (cherry picked from commit 8c0c3f2c471f9a1f9d7386070f71b91e6f655ec4) --- .../2026-09-22-agfhc-134-recipe-matrix.md | 58 +++++++++++++++++++ docs/test/agfhc.md | 28 +++++---- 2 files changed, 75 insertions(+), 11 deletions(-) create mode 100644 docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md diff --git a/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md b/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md new file mode 100644 index 000000000..0b24784b1 --- /dev/null +++ b/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md @@ -0,0 +1,58 @@ +# AGFHC 1.34.2 recipe matrix doc fix + +- **Date:** 2026-09-22 +- **Related PR(s):** TBD (target: pensando/gpu-operator main) +- **Related issue(s) / JIRA:** NO-JIRA + +## Context + +The AGFHC recipe × GPU support matrix in `docs/test/agfhc.md` had gaps +introduced when the doc was rewritten from a single-GPU (MI300X-only) +table to a multi-GPU matrix. The `acf_lvl*` recipe columns were dropped +and the MI350P row was incomplete. + +Verified by pulling the shipped test-runner image +(`amdpsdo/test-runner:agfhc-v1.5.2-12`, AGFHC 1.34.2) and listing +`/opt/amd/agfhc/recipes//*.yml` for every GPU directory. + +## Approach + +- Restore `acf_lvl1`–`acf_lvl4` columns to the recipe support matrix +- Fix MI350P row: mark `all_lvl5`, `single_pass`, `hbm_lvl5`, `acf_lvl*` + as supported (present in shipped image) +- Add MI350P to the partition profiles table (SPX/NPS1, 1 and 4 GPUs) +- Add `acf_lvl*` entries to the recipe name/title legend + +### Alternatives considered + +- Regenerate entire doc from scratch — rejected, too much churn for a + targeted fix. Automation guide kept as a local reference for future + releases. + +## Scope + +- **In scope:** `docs/test/agfhc.md` recipe matrix, partition profiles, + recipe legend. +- **Out of scope:** CLI arguments table (unchanged in 1.34.2), RVS docs, + MI358X (not yet user-facing), partition profiles for non-MI350P GPUs + (unchanged). + +## Validation + +- Pulled `amdpsdo/test-runner:agfhc-v1.5.2-12` and ran: + ``` + docker run --rm --entrypoint sh -c \ + 'ls /opt/amd/agfhc/recipes//*.yml' + ``` + for every GPU directory. Cross-referenced with + `github.amd.com/dctools/agfhc` `recipes/` directory via API. +- AGFHC release notes (v1.32.0 → v1.34.2) confirmed no new recipes or + platforms — changes were ROCm 10 compat + internal fixes only. + +## Risks and rollback + +- Low risk — doc-only change, no code impact. +- MI350P recipe additions are based on image filesystem presence; if any + were intentionally excluded by the AGFHC team as untested, they can be + reverted per-cell in a follow-up. +- Rollback: `git revert `. diff --git a/docs/test/agfhc.md b/docs/test/agfhc.md index 93449d90c..3fc7db98e 100644 --- a/docs/test/agfhc.md +++ b/docs/test/agfhc.md @@ -61,20 +61,24 @@ Please refer to the AGFHC documentation for available test recipes and additiona Here is the AGFHC test recipe support matrix and brief introduction to each recipe: -| GPU | all_lvl1 | all_lvl2 | all_lvl3 | all_lvl4 | all_lvl5 | all_perf | single_pass | gfx_lvl1 | gfx_lvl2 | gfx_lvl3 | gfx_lvl4 | hbm_lvl1 | hbm_lvl2 | hbm_lvl3 | hbm_lvl4 | hbm_lvl5 | dma_lvl1 | dma_lvl2 | dma_lvl3 | dma_lvl4 | hsio | pcie_lvl1 | pcie_lvl2 | pcie_lvl3 | pcie_lvl4 | rochpl_isolation | thermal | xgmi_lvl1 | xgmi_lvl2 | xgmi_lvl3 | xgmi_lvl4 | all_burnin_4h | all_burnin_12h | all_burnin_24h | hbm_burnin_8h | hbm_burnin_24h | -| --------- | -------- | -------- | -------- | -------- | -------- | -------- | ----------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | ---- | --------- | --------- | --------- | --------- | ---------------- | ------- | --------- | --------- | --------- | --------- | ------------- | -------------- | -------------- | ------------- | -------------- | -| MI300A | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | | | | | ✓ | | ✓ | ✓ | ✓ | ✓ | | | | | | -| MI300X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | -| MI300X-HF | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | -| MI308X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | -| MI308X-HF | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | -| MI325X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | -| MI350P | ✓ | ✓ | ✓ | ✓ | | ✓ | | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | | | | | | | | | | -| MI350X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | -| MI355X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | +| GPU | acf_lvl1 | acf_lvl2 | acf_lvl3 | acf_lvl4 | all_lvl1 | all_lvl2 | all_lvl3 | all_lvl4 | all_lvl5 | all_perf | single_pass | gfx_lvl1 | gfx_lvl2 | gfx_lvl3 | gfx_lvl4 | hbm_lvl1 | hbm_lvl2 | hbm_lvl3 | hbm_lvl4 | hbm_lvl5 | dma_lvl1 | dma_lvl2 | dma_lvl3 | dma_lvl4 | hsio | pcie_lvl1 | pcie_lvl2 | pcie_lvl3 | pcie_lvl4 | rochpl_isolation | thermal | xgmi_lvl1 | xgmi_lvl2 | xgmi_lvl3 | xgmi_lvl4 | all_burnin_4h | all_burnin_12h | all_burnin_24h | hbm_burnin_8h | hbm_burnin_24h | +| --------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | ----------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | -------- | ---- | --------- | --------- | --------- | --------- | ---------------- | ------- | --------- | --------- | --------- | --------- | ------------- | -------------- | -------------- | ------------- | -------------- | +| MI300A | | | | | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | | | | | ✓ | | ✓ | ✓ | ✓ | ✓ | | | | | | +| MI300X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | +| MI300X-HF | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | +| MI308X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | +| MI308X-HF | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | +| MI325X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | +| MI350P | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | | | | | | | | | | +| MI350X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | +| MI355X | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | ✓ | ✓ | | | | | | | Name | Title | | ------------------ | --------------------------------- | +| acf_lvl1 | A \~5m ACF workload | +| acf_lvl2 | A \~10m ACF workload | +| acf_lvl3 | A \~30m ACF workload | +| acf_lvl4 | A \~1h ACF workload | | all_burnin_12h | A \~12h check across system | | all_burnin_24h | A \~24h check across system | | all_burnin_4h | A \~4h check across system | @@ -133,6 +137,8 @@ The Instinct GPU models could be configured with certain GPU partition profiles | mi308x-hf | SPX | NPS1 | 8 | | mi300x-hf | SPX | NPS1 | 1 | | mi300x-hf | SPX | NPS1 | 8 | +| mi350p | SPX | NPS1 | 1 | +| mi350p | SPX | NPS1 | 4 | | mi350x | SPX | NPS1 | 1 | | mi350x | SPX | NPS1 | 8 | | mi355x | SPX | NPS1 | 1 | From 61abca6ddfc1e15aed4f964ac5528acd0a8d32a3 Mon Sep 17 00:00:00 2001 From: Praveen Kumar Shanmugam <58961022+spraveenio@users.noreply.github.com> Date: Tue, 22 Sep 2026 13:44:53 -0700 Subject: [PATCH 2/2] Delete docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md --- .../2026-09-22-agfhc-134-recipe-matrix.md | 58 ------------------- 1 file changed, 58 deletions(-) delete mode 100644 docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md diff --git a/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md b/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md deleted file mode 100644 index 0b24784b1..000000000 --- a/docs-internal/knowledge/plans/2026-09-22-agfhc-134-recipe-matrix.md +++ /dev/null @@ -1,58 +0,0 @@ -# AGFHC 1.34.2 recipe matrix doc fix - -- **Date:** 2026-09-22 -- **Related PR(s):** TBD (target: pensando/gpu-operator main) -- **Related issue(s) / JIRA:** NO-JIRA - -## Context - -The AGFHC recipe × GPU support matrix in `docs/test/agfhc.md` had gaps -introduced when the doc was rewritten from a single-GPU (MI300X-only) -table to a multi-GPU matrix. The `acf_lvl*` recipe columns were dropped -and the MI350P row was incomplete. - -Verified by pulling the shipped test-runner image -(`amdpsdo/test-runner:agfhc-v1.5.2-12`, AGFHC 1.34.2) and listing -`/opt/amd/agfhc/recipes//*.yml` for every GPU directory. - -## Approach - -- Restore `acf_lvl1`–`acf_lvl4` columns to the recipe support matrix -- Fix MI350P row: mark `all_lvl5`, `single_pass`, `hbm_lvl5`, `acf_lvl*` - as supported (present in shipped image) -- Add MI350P to the partition profiles table (SPX/NPS1, 1 and 4 GPUs) -- Add `acf_lvl*` entries to the recipe name/title legend - -### Alternatives considered - -- Regenerate entire doc from scratch — rejected, too much churn for a - targeted fix. Automation guide kept as a local reference for future - releases. - -## Scope - -- **In scope:** `docs/test/agfhc.md` recipe matrix, partition profiles, - recipe legend. -- **Out of scope:** CLI arguments table (unchanged in 1.34.2), RVS docs, - MI358X (not yet user-facing), partition profiles for non-MI350P GPUs - (unchanged). - -## Validation - -- Pulled `amdpsdo/test-runner:agfhc-v1.5.2-12` and ran: - ``` - docker run --rm --entrypoint sh -c \ - 'ls /opt/amd/agfhc/recipes//*.yml' - ``` - for every GPU directory. Cross-referenced with - `github.amd.com/dctools/agfhc` `recipes/` directory via API. -- AGFHC release notes (v1.32.0 → v1.34.2) confirmed no new recipes or - platforms — changes were ROCm 10 compat + internal fixes only. - -## Risks and rollback - -- Low risk — doc-only change, no code impact. -- MI350P recipe additions are based on image filesystem presence; if any - were intentionally excluded by the AGFHC team as untested, they can be - reverted per-cell in a follow-up. -- Rollback: `git revert `.