You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cdd089d
Browse filesBrowse the repository at this point in the historyBrowse files
Two correctness fixes from the Codex review on PR #115:
- _resource_scope derives a keyed resource's scope from its nearest owning
<X.Resources> ancestor, not the dictionary element. The explicit-wrapper form
<UserControl.Resources><ResourceDictionary>... previously recorded scope "root"
(the inner ResourceDictionary is not a property element), collapsing the
view-local-vs-global distinction the Phase-2 resource graph relies on. Now it
keeps "UserControl".
- document_facts also captures property-element bindings — <TextBlock.Text>
<Binding Path="Name" Converter="{StaticResource money}"/></...> — via a new
binding_from_element (attributes read like parse_binding reads the markup-ext
string, incl. a nested <Binding.RelativeSource>). The owning control/property
come from the parent <Type.Prop> element. These forms are common once a binding
needs a converter/relative-source, and were silently missing from bindings /
converters_used, so the Roslyn join would skip those paths.
Selftest grows to 19 checks (explicit-wrapper scope + property-element binding).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015zoG4YNCUf7RA5r8GAXMmb
0 commit comments