From 6fc8ab8ac3590f2a9fcc0e0422d15c764f8baa47 Mon Sep 17 00:00:00 2001 From: chaneylc Date: Fri, 13 Feb 2026 11:24:26 -0600 Subject: [PATCH] fix bug in permission helpers --- dependencies.gradle | 2 +- .../java/org/phenoapps/security/SecureActivityImpl.kt | 9 ++++----- .../java/org/phenoapps/security/SecureFragmentImpl.kt | 9 ++++----- 3 files changed, 9 insertions(+), 11 deletions(-) diff --git a/dependencies.gradle b/dependencies.gradle index e91ee260..262de126 100644 --- a/dependencies.gradle +++ b/dependencies.gradle @@ -2,7 +2,7 @@ ext.versions = [ minSdk: 16, compileSdk: 33, buildTools: "29.0.3", - publishVersion: "0.9.54", + publishVersion: "0.9.55", publishVersionCode: 1 ] diff --git a/phenolib/src/main/java/org/phenoapps/security/SecureActivityImpl.kt b/phenolib/src/main/java/org/phenoapps/security/SecureActivityImpl.kt index db873c51..44cfb428 100644 --- a/phenolib/src/main/java/org/phenoapps/security/SecureActivityImpl.kt +++ b/phenolib/src/main/java/org/phenoapps/security/SecureActivityImpl.kt @@ -39,11 +39,10 @@ open class SecureActivityImpl(private val activity: FragmentActivity): SecureFra //set the callback if permissions are not already granted mOnResultCallback = onResult - //check permission that aren't granted which are needed - val needed = permissions.associateBy { - ActivityCompat.checkSelfPermission(activity, it) == PackageManager.PERMISSION_GRANTED - }.filter { !it.key } - .map { it.value } + //check permissions that aren't granted which are needed + val needed = permissions.filter { + ActivityCompat.checkSelfPermission(activity, it) != PackageManager.PERMISSION_GRANTED + } if (needed.isNotEmpty()) { diff --git a/phenolib/src/main/java/org/phenoapps/security/SecureFragmentImpl.kt b/phenolib/src/main/java/org/phenoapps/security/SecureFragmentImpl.kt index 51fa15fd..aa576e2d 100644 --- a/phenolib/src/main/java/org/phenoapps/security/SecureFragmentImpl.kt +++ b/phenolib/src/main/java/org/phenoapps/security/SecureFragmentImpl.kt @@ -39,11 +39,10 @@ open class SecureFragmentImpl(private val fragment: Fragment): SecureFragmentInt fragment.context?.let { ctx -> - //check permission that aren't granted which are needed - val needed = permissions.associateBy { - ActivityCompat.checkSelfPermission(ctx, it) == PackageManager.PERMISSION_GRANTED - }.filter { !it.key } - .map { it.value } + //check permissions that aren't granted which are needed + val needed = permissions.filter { + ActivityCompat.checkSelfPermission(ctx, it) != PackageManager.PERMISSION_GRANTED + } if (needed.isNotEmpty()) {