Add "Grant access to other archives" to share management#385
Merged
Conversation
flaviahandrea-vsp
commented
Jun 8, 2026
flaviahandrea-vsp
commented
Contributor
- New flow to grant a record's share access to another archive by searching its owner's email, with a view/contributor/curator/owner role selector.
- New screens: FindArchiveByEmailPage (email search + results) and GrantArchiveAccessPage (confirm archive + role), wired into ShareManagementContainer via new FIND_ARCHIVE_BY_EMAIL / GRANT_ARCHIVE_ACCESS pages.
- New entry point section on ShareItemPage ("Find an archive using email" / "Select from past shares" — latter stubbed, out of scope).
- Backend wiring: search/archiveByEmail endpoint + grantArchiveAccess across IArchiveService, NetworkClient, RequestContainer.addShare, and the Archive/Share repositories.
- ShareManagementViewModel: email search with validation, normalization, and stale-response guarding; grant-access role state and confirm handler.
- Reordered the role list in AccessRolesPage (Viewer → … → Owner).
- Extracted shared ShareManagementComponents (ArchiveThumbnail, AccessRole.iconRes(), GrantAccessEntryRow) to remove duplication; this also fixed a latent MANAGER -> TODO() crash in ArchiveAccessPage.
- New flow to grant a record's share access to another archive by searching its owner's email, with a view/contributor/curator/owner role selector.
- New screens: FindArchiveByEmailPage (email search + results) and GrantArchiveAccessPage (confirm archive + role), wired into ShareManagementContainer via new FIND_ARCHIVE_BY_EMAIL / GRANT_ARCHIVE_ACCESS pages.
- New entry point section on ShareItemPage ("Find an archive using email" / "Select from past shares" — latter stubbed, out of scope).
- Backend wiring: search/archiveByEmail endpoint + grantArchiveAccess across IArchiveService, NetworkClient, RequestContainer.addShare, and the Archive/Share repositories.
- ShareManagementViewModel: email search with validation, normalization, and stale-response guarding; grant-access role state and confirm handler.
- Reordered the role list in AccessRolesPage (Viewer → … → Owner).
- Extracted shared ShareManagementComponents (ArchiveThumbnail, AccessRole.iconRes(), GrantAccessEntryRow) to remove duplication; this also fixed a latent MANAGER -> TODO() crash in ArchiveAccessPage.
luciancerbu-vsp
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.