From 667f3f01f64a05c162e7feab25d2aaec66ae0112 Mon Sep 17 00:00:00 2001
From: pasta
Date: Wed, 30 Sep 2026 10:09:11 -0500
Subject: [PATCH 1/3] feat(web): Labels and Milestones pages to create, edit
and delete them
QW-019: there was no web UI to create or manage milestones or labels; the issue picker pointed at 'dg milestone create' and labels could only be created inline, with no recolor, description edit or delete.
Issues and Pull requests now carry a Labels | Milestones switch, as on GitHub. /repo/labels lists the labels with links to their issues and PRs and lets members create one (name, description, colour with GitHub's palette and a preview), edit its colour and description, and delete it (the signer's definitions, retiring it first when another member also defined it, parity with dg label delete); retired labels can be restored. /repo/milestones lists open and closed milestones with due dates, descriptions and progress over their issues and PRs, and lets members create, edit, close, reopen and delete them (refused, with close offered, when another member also defined the title). Names and titles stay fixed once defined, since issues carry them by name. Private repositories' milestones stay refused, as in dg. The issue sidebar's pickers link to both pages.
Co-Authored-By: Claude Opus 5.5 (1M context)
---
docs/guides/collaborating.md | 17 +-
forge-web/app/repo/labels/client.tsx | 14 +
forge-web/app/repo/labels/page.tsx | 11 +
forge-web/app/repo/milestones/client.tsx | 14 +
forge-web/app/repo/milestones/page.tsx | 11 +
forge-web/components/repo/issue-content.tsx | 4 +-
forge-web/components/repo/issues-content.tsx | 2 +
forge-web/components/repo/labels-content.tsx | 337 ++++++++++++++++
.../repo/labels-milestones.test.tsx | 171 ++++++++
.../components/repo/milestones-content.tsx | 367 ++++++++++++++++++
forge-web/components/repo/pull-content.tsx | 1 +
forge-web/components/repo/pulls-content.tsx | 2 +
forge-web/components/repo/repo-header.test.ts | 2 +
forge-web/components/repo/repo-header.tsx | 3 +-
forge-web/components/repo/target-rail.tsx | 23 +-
forge-web/components/repo/triage-nav.tsx | 28 ++
forge-web/lib/page-title.ts | 2 +
forge-web/lib/repo/index.ts | 3 +
forge-web/lib/repo/issue-index.ts | 14 +
.../lib/repo/label-milestone-writes.test.ts | 119 ++++++
forge-web/lib/repo/labels.ts | 44 ++-
forge-web/lib/repo/milestones.ts | 109 +++++-
forge-web/lib/repo/pull-index.ts | 11 +
forge-web/lib/short-url.test.ts | 4 +
forge-web/lib/short-url.ts | 10 +-
25 files changed, 1304 insertions(+), 19 deletions(-)
create mode 100644 forge-web/app/repo/labels/client.tsx
create mode 100644 forge-web/app/repo/labels/page.tsx
create mode 100644 forge-web/app/repo/milestones/client.tsx
create mode 100644 forge-web/app/repo/milestones/page.tsx
create mode 100644 forge-web/components/repo/labels-content.tsx
create mode 100644 forge-web/components/repo/labels-milestones.test.tsx
create mode 100644 forge-web/components/repo/milestones-content.tsx
create mode 100644 forge-web/components/repo/triage-nav.tsx
create mode 100644 forge-web/lib/repo/label-milestone-writes.test.ts
diff --git a/docs/guides/collaborating.md b/docs/guides/collaborating.md
index 6b360bafe..cbf858e37 100644
--- a/docs/guides/collaborating.md
+++ b/docs/guides/collaborating.md
@@ -340,6 +340,21 @@ dg label delete / bug # deletes your definitions; r
dg issue label / 12 --add bug
```
+On the web, **Issues → Labels** lists them and lets members create one, change its colour or description, and delete it (with the same retire-if-others-defined-it rule). A label keeps its name once defined: issues carry a label by its name, so a rename would leave them under the old one.
+
+### Milestones
+
+Members (maintainers and writers) define milestones and put issues and PRs in them:
+
+```sh
+dg milestone create / v1.0 --description "First release" --due 2026-12-01
+dg milestone list /
+dg milestone close / v1.0 # --reopen to reopen
+dg issue milestone / 12 v1.0
+```
+
+On the web, **Issues → Milestones** lists them open and closed, with due dates and progress, and lets members create, edit, close, reopen and delete them. Like a label, a milestone keeps its title once defined. A milestone definition can be deleted only by the member who wrote it, so one another member also defined can be closed but not deleted. Milestones in a private repository are sealed, which this release does not do yet (web or `dg`).
+
### Stars
```sh
@@ -356,7 +371,7 @@ On forge.dashhq.org, signed in with a limited key ([Identity and keys](identity-
| You can | Not yet (coming soon) |
|---|---|
| Browse code, commits, branches, tags and PR diffs; download a branch as a zip | Web editing of files |
-| File issues, comment, close and reopen; label them (members) | Merging a private repository's PRs, or committing to its branches (use `dg`) |
+| File issues, comment, close and reopen; label them and put them in milestones, and manage the repo's labels and milestones (members) | Merging a private repository's PRs, or committing to its branches (use `dg`) |
| Open a PR from a branch you have already pushed, in the repository or your fork | Merging when both sides changed the same files (use `dg pr merge`) |
| Review a PR: approve, request changes or comment, with inline comments, suggestions and a pending review | |
| Merge a PR (see below) | |
diff --git a/forge-web/app/repo/labels/client.tsx b/forge-web/app/repo/labels/client.tsx
new file mode 100644
index 000000000..68c4ae794
--- /dev/null
+++ b/forge-web/app/repo/labels/client.tsx
@@ -0,0 +1,14 @@
+'use client'
+
+import { RepoScaffold } from '@/components/repo/repo-scaffold'
+import { LabelsContent } from '@/components/repo/labels-content'
+import { useRepoAddress } from '@/hooks/use-query-param'
+
+export function LabelsClient(): JSX.Element {
+ const addr = useRepoAddress()
+ return (
+
+ {(home) => }
+
+ )
+}
diff --git a/forge-web/app/repo/labels/page.tsx b/forge-web/app/repo/labels/page.tsx
new file mode 100644
index 000000000..820d1f358
--- /dev/null
+++ b/forge-web/app/repo/labels/page.tsx
@@ -0,0 +1,11 @@
+import { QueryPage } from '@/components/route-loading'
+import { LabelsClient } from './client'
+
+/** `/repo/labels?owner=&name=` — the repo's labels: list, create, edit, delete (QW-019). */
+export default function LabelsPage(): JSX.Element {
+ return (
+
+
+
+ )
+}
diff --git a/forge-web/app/repo/milestones/client.tsx b/forge-web/app/repo/milestones/client.tsx
new file mode 100644
index 000000000..b34e2645e
--- /dev/null
+++ b/forge-web/app/repo/milestones/client.tsx
@@ -0,0 +1,14 @@
+'use client'
+
+import { RepoScaffold } from '@/components/repo/repo-scaffold'
+import { MilestonesContent } from '@/components/repo/milestones-content'
+import { useRepoAddress } from '@/hooks/use-query-param'
+
+export function MilestonesClient(): JSX.Element {
+ const addr = useRepoAddress()
+ return (
+
+ {(home) => }
+
+ )
+}
diff --git a/forge-web/app/repo/milestones/page.tsx b/forge-web/app/repo/milestones/page.tsx
new file mode 100644
index 000000000..d43555da8
--- /dev/null
+++ b/forge-web/app/repo/milestones/page.tsx
@@ -0,0 +1,11 @@
+import { QueryPage } from '@/components/route-loading'
+import { MilestonesClient } from './client'
+
+/** `/repo/milestones?owner=&name=` — the repo's milestones: open / closed, progress, create, edit, close, delete (QW-019). */
+export default function MilestonesPage(): JSX.Element {
+ return (
+
+
+
+ )
+}
diff --git a/forge-web/components/repo/issue-content.tsx b/forge-web/components/repo/issue-content.tsx
index 0be2ace22..a6d6fafa6 100644
--- a/forge-web/components/repo/issue-content.tsx
+++ b/forge-web/components/repo/issue-content.tsx
@@ -54,7 +54,7 @@ import { useSdk } from '@/hooks/use-sdk'
import { useAsync } from '@/hooks/use-async'
import { useIntent } from '@/hooks/use-intent'
import { useFirstWrite } from '@/hooks/use-first-write'
-import { useParam, type RepoAddress } from '@/hooks/use-query-param'
+import { repoHref, useParam, type RepoAddress } from '@/hooks/use-query-param'
import { useRepoLinks } from '@/components/repo/target-href'
import { importedUrlOf } from '@/lib/view/ref-targets'
import { CopyLinkButton } from '@/components/ui/copy-link'
@@ -492,6 +492,7 @@ export function IssueContent({ home, addr, number }: { home: RepoHome; addr?: Re
canDefine={!isPrivate}
canEdit={isMember && !archived && guard.disabledReason === null}
onChoose={(title) => setPending({ kind: 'milestone', title })}
+ {...(addr ? { manageHref: repoHref('/repo/milestones', addr, { new: '1' }) } : {})}
/>
{isMember || meta.pinned || meta.locked ? (
@@ -517,6 +518,7 @@ export function IssueContent({ home, addr, number }: { home: RepoHome; addr?: Re
canEdit={isMember && !archived && guard.disabledReason === null}
onToggle={(label, remove) => setPending({ kind: 'label', label, remove })}
onDefine={(name, color, description) => setPending({ kind: 'defineLabel', name, color, description, apply: true })}
+ {...(addr ? { manageHref: repoHref('/repo/labels', addr) } : {})}
/>
{isPrivate ?
The labels on this issue are encrypted; the label definitions (names, colours, descriptions) are not.
: null}
diff --git a/forge-web/components/repo/issues-content.tsx b/forge-web/components/repo/issues-content.tsx
index 327acd684..527a7e85b 100644
--- a/forge-web/components/repo/issues-content.tsx
+++ b/forge-web/components/repo/issues-content.tsx
@@ -81,6 +81,7 @@ import {
import { IssueTemplatePicker } from '@/components/repo/issue-templates'
import { useRepoTotals } from '@/components/repo/use-repo-totals'
import { useMilestones } from '@/components/repo/use-milestones'
+import { TriageNav } from '@/components/repo/triage-nav'
import { BodyCounter, SealedLimit, composeCost, privateComposeBlock } from '@/components/repo/private-compose'
import type { RepoAddress } from '@/hooks/use-query-param'
import { repoHref } from '@/hooks/use-query-param'
@@ -143,6 +144,7 @@ export function IssuesContent({ home, addr }: { home: RepoHome; addr: RepoAddres
+
{canCompose ? (
) : null}
diff --git a/forge-web/components/repo/triage-nav.tsx b/forge-web/components/repo/triage-nav.tsx
new file mode 100644
index 000000000..478bc8c16
--- /dev/null
+++ b/forge-web/components/repo/triage-nav.tsx
@@ -0,0 +1,28 @@
+'use client'
+
+import Link from 'next/link'
+import { Milestone, Tag } from 'lucide-react'
+import { repoHref, type RepoAddress } from '@/hooks/use-query-param'
+import { cn } from '@/lib/utils'
+
+/** The Labels | Milestones switch GitHub puts beside the issue search (QW-019). */
+export function TriageNav({ addr, current }: { addr: RepoAddress; current?: 'labels' | 'milestones' }): JSX.Element {
+ const item = (key: 'labels' | 'milestones', label: string, Icon: typeof Tag): JSX.Element => {
+ const on = current === key
+ const cls = cn(
+ 'inline-flex items-center gap-1.5 rounded px-2.5 py-1 whitespace-nowrap coarse:min-h-11',
+ on ? 'bg-anvil-100 font-medium text-anvil-900 dark:bg-anvil-800 dark:text-anvil-50' : 'text-anvil-600 hover:text-anvil-900 dark:text-anvil-300 dark:hover:text-anvil-50',
+ )
+ return (
+
+ {label}
+
+ )
+ }
+ return (
+
+ )
+}
diff --git a/forge-web/lib/page-title.ts b/forge-web/lib/page-title.ts
index 77306ffe9..a7fa53c4e 100644
--- a/forge-web/lib/page-title.ts
+++ b/forge-web/lib/page-title.ts
@@ -47,6 +47,8 @@ const REPO_TITLES: Readonly string>>
'/repo/branches': (_q, repo) => `Branches · ${repo}`,
'/repo/tags': (_q, repo) => `Tags · ${repo}`,
'/repo/stargazers': (_q, repo) => `Stargazers · ${repo}`,
+ '/repo/labels': (_q, repo) => `Labels · ${repo}`,
+ '/repo/milestones': (_q, repo) => `Milestones · ${repo}`,
'/repo/settings': (_q, repo) => `Settings · ${repo}`,
}
diff --git a/forge-web/lib/repo/index.ts b/forge-web/lib/repo/index.ts
index 6c3000d78..cd3c909d9 100644
--- a/forge-web/lib/repo/index.ts
+++ b/forge-web/lib/repo/index.ts
@@ -154,6 +154,7 @@ export {
} from './issues'
export {
checkLabelInput,
+ deleteLabel,
defineLabel,
labelTextColor,
LABEL_COLORS,
@@ -167,6 +168,7 @@ export {
compareRows,
matchesText,
mentions,
+ issueMilestoneItems,
queryIssues,
rowFiltersOf,
rowMatches,
@@ -176,6 +178,7 @@ export {
type RowFilters,
} from './issue-index'
export {
+ pullMilestoneItems,
pullsLinking,
queryPulls,
type LinkingPulls,
diff --git a/forge-web/lib/repo/issue-index.ts b/forge-web/lib/repo/issue-index.ts
index 7f1ace9f8..28abd2775 100644
--- a/forge-web/lib/repo/issue-index.ts
+++ b/forge-web/lib/repo/issue-index.ts
@@ -354,3 +354,17 @@ async function pinnedRows(sdk: EvoSDK, index: IssueIndex): Promise {
await resolveIds(sdk, index, ids)
return rowsOf(index, ids)
}
+
+/**
+ * Each issue a milestone event names, with its open state and milestone: the milestones page's
+ * progress (`foldMilestonesV2`'s items). Read from the feed the list shares (the targets with a
+ * `milestoneSet` event, resolved by id); null when the feed was too large to read, so the
+ * progress is unknown rather than wrong.
+ */
+export async function issueMilestoneItems(sdk: EvoSDK, repo: RepoRef, network: Network = DEFAULT_NETWORK): Promise<{ open: boolean; milestone: string | null }[] | null> {
+ const index = await indexOf(sdk, repo, network)
+ if (index.feed === null) return null
+ const ids = [...index.feed].filter(([, log]) => log.events.some((e) => e.kind === 'milestoneSet')).map(([id]) => id)
+ await resolveIds(sdk, index, ids)
+ return rowsOf(index, ids).map((r) => ({ open: r.state.open, milestone: r.milestone ?? null }))
+}
diff --git a/forge-web/lib/repo/label-milestone-writes.test.ts b/forge-web/lib/repo/label-milestone-writes.test.ts
new file mode 100644
index 000000000..8c72c1bff
--- /dev/null
+++ b/forge-web/lib/repo/label-milestone-writes.test.ts
@@ -0,0 +1,119 @@
+/**
+ * QW-019: deleting a label or a milestone. Both documents are owner-deletable only and "newest
+ * definition wins", so a delete removes the signer's definitions, and when another member also
+ * defined the name: a label is retired first (parity with forge-core `delete_label`), a
+ * milestone is refused (its older definition would come back).
+ */
+
+import type { EvoSDK } from '@dashevo/evo-sdk'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
+
+import type { RepoRef } from './contract'
+
+const ME = 'MeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMeMe'
+const OTHER = 'OtherOtherOtherOtherOtherOtherOtherOtherOthe'
+/** The documents a query answers, by document type. */
+let stored: Record[]> = {}
+const created: { type: string; data: Record }[] = []
+const deleted: { type: string; id: string }[] = []
+
+vi.mock('../sdk', async (orig) => ({
+ ...(await orig()),
+ queryAllDocuments: async (_sdk: unknown, q: { documentTypeName: string; where?: [string, string, unknown][] }) => {
+ let docs = stored[q.documentTypeName] ?? []
+ for (const [field, , v] of q.where ?? []) if (field !== 'repoId') docs = docs.filter((d) => d[field] === v)
+ return docs
+ },
+ createDocumentIdempotent: async (_sdk: unknown, _auth: unknown, p: { documentType: string; data: Record }) => {
+ created.push({ type: p.documentType, data: p.data })
+ return { documentId: 'new', confirmed: true, cost: { credits: 0, dash: 0 }, actualCredits: 0 }
+ },
+ deleteDocumentIdempotent: async (_sdk: unknown, _auth: unknown, p: { documentType: string; documentId: string }) => {
+ deleted.push({ type: p.documentType, id: p.documentId })
+ return { deleted: true, actualCredits: 0 }
+ },
+}))
+vi.mock('./writes', async (orig) => ({
+ ...(await orig()),
+ writeRepoDoc: async (_sdk: unknown, _auth: unknown, _repo: unknown, type: string, data: Record) => {
+ created.push({ type, data })
+ return { documentId: 'new', confirmed: true, cost: { credits: 0, dash: 0 }, actualCredits: 0 }
+ },
+}))
+
+const { deleteLabel } = await import('./labels')
+const { dayOf, defineMilestone, deleteMilestone, dueOnOf } = await import('./milestones')
+
+const REPO: RepoRef = {
+ forge: { core: 'CORE', collab: 'COLLAB', community: 'COMMUNITY', group: 'GROUP' },
+ repoId: 'C8XSf6R4shR1kqFKUZQnuaEZ5DkW7uoe9qtQYZpS5SRd',
+ ownerId: ME,
+ name: 'repo',
+ visibility: 'public',
+}
+const AUTH = { identityId: ME, network: 'devnet' as const, getSigningKeyWif: () => 'W' }
+const sdk = {} as EvoSDK
+
+beforeEach(() => {
+ stored = {}
+ created.length = 0
+ deleted.length = 0
+})
+
+describe('deleteLabel', () => {
+ it('deletes every definition when all are the signer\'s', async () => {
+ stored['label'] = [
+ { $id: 'l1', $ownerId: ME, $createdAt: 1, name: 'bug' },
+ { $id: 'l2', $ownerId: ME, $createdAt: 2, name: 'bug' },
+ { $id: 'x', $ownerId: OTHER, $createdAt: 3, name: 'docs' },
+ ]
+ expect(await deleteLabel(sdk, AUTH, REPO, 'bug')).toEqual({ retired: false, deleted: 2 })
+ expect(deleted.map((d) => d.id)).toEqual(['l1', 'l2'])
+ expect(created).toEqual([])
+ })
+
+ it("retires it first when another member also defined it, then deletes the signer's", async () => {
+ stored['label'] = [
+ { $id: 'o1', $ownerId: OTHER, $createdAt: 1, name: 'bug' },
+ { $id: 'l2', $ownerId: ME, $createdAt: 2, name: 'bug' },
+ ]
+ expect(await deleteLabel(sdk, AUTH, REPO, 'bug')).toEqual({ retired: true, deleted: 1 })
+ expect(created).toHaveLength(1)
+ expect(created[0]?.data).toMatchObject({ name: 'bug', retired: true })
+ expect(deleted.map((d) => d.id)).toEqual(['l2'])
+ })
+
+ it('writes nothing for a label that is not defined', async () => {
+ expect(await deleteLabel(sdk, AUTH, REPO, 'nope')).toEqual({ retired: false, deleted: 0 })
+ expect(created).toEqual([])
+ expect(deleted).toEqual([])
+ })
+})
+
+describe('milestones', () => {
+ it('reads a due day as UTC midnight and back', () => {
+ expect(dueOnOf('2026-12-01')).toBe(1_796_083_200_000) // the CLI's parse_day
+ expect(dayOf(1_796_083_200_000)).toBe('2026-12-01')
+ for (const bad of ['2026-02-30', '1969-12-31', '2026-13-01', 'soon', '']) expect(dueOnOf(bad)).toBeNull()
+ })
+
+ it('defines a milestone with what the schema allows, and refuses a private repo', async () => {
+ await defineMilestone(sdk, AUTH, REPO, { title: ' v1.0 ', description: 'First', dueOn: 1_796_083_200_000, closed: false })
+ expect(created).toEqual([{ type: 'milestone', data: { title: 'v1.0', closed: false, description: 'First', dueOn: 1_796_083_200_000 } }])
+ await expect(defineMilestone(sdk, AUTH, { ...REPO, visibility: 'private' }, { title: 'v1' })).rejects.toThrow(/sealed/)
+ await expect(defineMilestone(sdk, AUTH, REPO, { title: 'x'.repeat(64) })).rejects.toThrow(/63/)
+ })
+
+ it("deletes the signer's definitions, and refuses when another member also defined the title", async () => {
+ stored['milestone'] = [
+ { $id: 'm1', $ownerId: ME, $createdAt: 1, title: 'v1.0' },
+ { $id: 'm2', $ownerId: ME, $createdAt: 2, title: 'v1.0', closed: true },
+ { $id: 'm3', $ownerId: OTHER, $createdAt: 3, title: 'v2.0' },
+ { $id: 'm4', $ownerId: ME, $createdAt: 4, title: 'v2.0' },
+ ]
+ expect(await deleteMilestone(sdk, AUTH, REPO, 'v1.0')).toBe(2)
+ expect(deleted.map((d) => d.id)).toEqual(['m1', 'm2'])
+ await expect(deleteMilestone(sdk, AUTH, REPO, 'v2.0')).rejects.toThrow(/another member/)
+ expect(deleted.map((d) => d.id)).toEqual(['m1', 'm2'])
+ })
+})
diff --git a/forge-web/lib/repo/labels.ts b/forge-web/lib/repo/labels.ts
index 99afce6cc..759fc0fa9 100644
--- a/forge-web/lib/repo/labels.ts
+++ b/forge-web/lib/repo/labels.ts
@@ -10,7 +10,7 @@
import type { EvoSDK } from '@dashevo/evo-sdk'
import { decodeIdentifier } from '../auth/base58'
-import { createDocumentIdempotent, queryAllDocuments, type PlainDocument, type WriteAuth, type WriteResult } from '../sdk'
+import { createDocumentIdempotent, deleteDocumentIdempotent, queryAllDocuments, type PlainDocument, type WriteAuth, type WriteResult } from '../sdk'
import { compareStrings } from '../rules/oid'
import { DOC, num, str, type RepoRef } from './contract'
import { repoSource } from './source'
@@ -101,6 +101,48 @@ export function defineLabel(
})
}
+/** One definition document of a label, with its signer (a definition is deletable by its owner only). */
+export interface LabelDocRef {
+ readonly id: string
+ readonly owner: string
+ readonly createdAt: number
+}
+
+/** Every definition document of label `name` in `repo`, oldest first (the `(repoId, name, $createdAt)` index). */
+export async function readLabelDocs(sdk: EvoSDK, repo: RepoRef, name: string): Promise {
+ const docs = await queryAllDocuments(
+ sdk,
+ repoSource(repo).repoQuery(DOC.label, { where: [['name', '==', name]], orderBy: [['name', 'asc'], ['$createdAt', 'asc']] }),
+ )
+ return docs.map((d) => ({ id: str(d, '$id'), owner: str(d, '$ownerId'), createdAt: num(d, '$createdAt') }))
+}
+
+/**
+ * Delete label `name` (parity: forge-core `Collab::delete_label`). A `label` document is
+ * deletable by its owner only, so: when every definition of the name is the signer's, they are
+ * all deleted (the label is gone); otherwise a retirement is written first (the newest definition
+ * wins, so every reader stops offering it) and the signer's older definitions are deleted,
+ * keeping that retirement. The labels already on issues and PRs are their history and stay.
+ * `retired`: a retirement was written; `deleted`: definition documents removed.
+ */
+export async function deleteLabel(
+ sdk: EvoSDK,
+ auth: WriteAuth,
+ repo: RepoRef,
+ name: string,
+ intent?: string,
+): Promise<{ readonly retired: boolean; readonly deleted: number }> {
+ const docs = await readLabelDocs(sdk, repo, name)
+ if (docs.length === 0) return { retired: false, deleted: 0 }
+ const mine = docs.filter((d) => d.owner === auth.identityId)
+ const retired = mine.length < docs.length
+ if (retired) await defineLabel(sdk, auth, repo, { name, retired: true, ...(intent ? { intent: `${intent}:retire` } : {}) })
+ for (const d of mine) {
+ await deleteDocumentIdempotent(sdk, auth, { contractId: repo.forge.core, documentType: DOC.label, documentId: d.id, repo: repo.repoId })
+ }
+ return { retired, deleted: mine.length }
+}
+
/** GitHub's default label palette, offered when defining a label. */
export const LABEL_COLORS: readonly string[] = [
'#b60205', '#d93f0b', '#fbca04', '#0e8a16', '#006b75', '#1d76db', '#0052cc', '#5319e7',
diff --git a/forge-web/lib/repo/milestones.ts b/forge-web/lib/repo/milestones.ts
index cc6905a3f..9a6466eb6 100644
--- a/forge-web/lib/repo/milestones.ts
+++ b/forge-web/lib/repo/milestones.ts
@@ -7,23 +7,112 @@
import type { EvoSDK } from '@dashevo/evo-sdk'
import { foldMilestonesV2, type Milestone, type MilestoneDoc, type MilestoneItem } from '../rules/parity'
-import { queryAllDocuments } from '../sdk'
+import { deleteDocumentIdempotent, queryAllDocuments, type PlainDocument, type WriteAuth, type WriteResult } from '../sdk'
+import { utf8Length } from '../view/issue-query'
import { DOC, num, str, type RepoRef } from './contract'
import { repoSource } from './source'
+import { contractFor, writeRepoDoc } from './writes'
-/** A repo's milestones with their progress over `items` (each issue's open state and milestone). */
-export async function readMilestones(sdk: EvoSDK, repo: RepoRef, items: readonly MilestoneItem[] = []): Promise {
- const docs = await queryAllDocuments(
- sdk,
- repoSource(repo).repoQuery(DOC.milestone, { orderBy: [['repoId', 'asc'], ['title', 'asc'], ['$createdAt', 'asc']] }),
- )
- const rows: MilestoneDoc[] = docs.map((d) => ({
+/** Every `milestone` document of `repo` (all definitions, oldest first per title). */
+function readMilestoneDocs(sdk: EvoSDK, repo: RepoRef): Promise {
+ return queryAllDocuments(sdk, repoSource(repo).repoQuery(DOC.milestone, { orderBy: [['repoId', 'asc'], ['title', 'asc'], ['$createdAt', 'asc']] }))
+}
+
+function milestoneDocOf(d: PlainDocument): MilestoneDoc {
+ return {
id: str(d, '$id'),
title: str(d, 'title'),
description: str(d, 'description'),
dueOn: typeof d['dueOn'] === 'number' ? d['dueOn'] : null,
closed: d['closed'] === true,
createdAt: num(d, '$createdAt'),
- }))
- return foldMilestonesV2(rows, items)
+ }
+}
+
+/** A repo's milestones with their progress over `items` (each issue's open state and milestone). */
+export async function readMilestones(sdk: EvoSDK, repo: RepoRef, items: readonly MilestoneItem[] = []): Promise {
+ return foldMilestonesV2((await readMilestoneDocs(sdk, repo)).map(milestoneDocOf), items)
+}
+
+/** A milestone's definition documents' ids and signers, by title (a definition is deletable by its owner only). */
+export async function readMilestoneOwners(sdk: EvoSDK, repo: RepoRef): Promise
{m.description ?
{m.description}
: null}
+ {/* The counts cover both, so both lists are a click away (the title opens the issues). */}
+
Progress unknown: the repo's event history is too large to read completely.
+
+ {data?.progress === 'failed'
+ ? "Progress unknown: the repo's issues or pull requests could not be read."
+ : "Progress unknown: the repo's event history is too large to read completely."}
+
-
- {choices.some((c) => !c.closed) ? 'Manage milestones' : 'Create a milestone'}
+ {/* With none open the page opens on its New milestone form; otherwise on the list. */}
+
+ {anyOpen ? : } {anyOpen ? 'Manage milestones' : 'Create a milestone'}
) : null}
diff --git a/forge-web/lib/repo/index.ts b/forge-web/lib/repo/index.ts
index cd3c909d9..22a34450a 100644
--- a/forge-web/lib/repo/index.ts
+++ b/forge-web/lib/repo/index.ts
@@ -160,6 +160,8 @@ export {
LABEL_COLORS,
LABEL_LIMITS,
newestLabels,
+ planLabelDelete,
+ readLabelDocs,
readLabels,
toLabelDef,
type LabelDef,
diff --git a/forge-web/lib/repo/issue-index.ts b/forge-web/lib/repo/issue-index.ts
index 28abd2775..01cd2b491 100644
--- a/forge-web/lib/repo/issue-index.ts
+++ b/forge-web/lib/repo/issue-index.ts
@@ -43,6 +43,7 @@ import {
resolveIds,
rowsInAnyState,
rowsOf,
+ rowsWithEvent,
selectRows,
transitionTargets,
type ListIndex,
@@ -362,9 +363,6 @@ async function pinnedRows(sdk: EvoSDK, index: IssueIndex): Promise {
* progress is unknown rather than wrong.
*/
export async function issueMilestoneItems(sdk: EvoSDK, repo: RepoRef, network: Network = DEFAULT_NETWORK): Promise<{ open: boolean; milestone: string | null }[] | null> {
- const index = await indexOf(sdk, repo, network)
- if (index.feed === null) return null
- const ids = [...index.feed].filter(([, log]) => log.events.some((e) => e.kind === 'milestoneSet')).map(([id]) => id)
- await resolveIds(sdk, index, ids)
- return rowsOf(index, ids).map((r) => ({ open: r.state.open, milestone: r.milestone ?? null }))
+ const rows = await rowsWithEvent(sdk, await indexOf(sdk, repo, network), 'milestoneSet')
+ return rows?.map((r) => ({ open: r.state.open, milestone: r.milestone ?? null })) ?? null
}
diff --git a/forge-web/lib/repo/labels.ts b/forge-web/lib/repo/labels.ts
index 759fc0fa9..ec23a6059 100644
--- a/forge-web/lib/repo/labels.ts
+++ b/forge-web/lib/repo/labels.ts
@@ -117,6 +117,16 @@ export async function readLabelDocs(sdk: EvoSDK, repo: RepoRef, name: string): P
return docs.map((d) => ({ id: str(d, '$id'), owner: str(d, '$ownerId'), createdAt: num(d, '$createdAt') }))
}
+/**
+ * What {@link deleteLabel} writes for `docs` (a label's definitions) signed by `me`: a retirement
+ * first when someone else also defined it, then a delete of each of `me`'s definitions. Nothing
+ * for a name with no definitions. The confirm dialog prices this before anything is signed.
+ */
+export function planLabelDelete(docs: readonly LabelDocRef[], me: string): { readonly retire: boolean; readonly mine: readonly LabelDocRef[] } {
+ const mine = docs.filter((d) => d.owner === me)
+ return { retire: mine.length < docs.length, mine }
+}
+
/**
* Delete label `name` (parity: forge-core `Collab::delete_label`). A `label` document is
* deletable by its owner only, so: when every definition of the name is the signer's, they are
@@ -132,10 +142,7 @@ export async function deleteLabel(
name: string,
intent?: string,
): Promise<{ readonly retired: boolean; readonly deleted: number }> {
- const docs = await readLabelDocs(sdk, repo, name)
- if (docs.length === 0) return { retired: false, deleted: 0 }
- const mine = docs.filter((d) => d.owner === auth.identityId)
- const retired = mine.length < docs.length
+ const { retire: retired, mine } = planLabelDelete(await readLabelDocs(sdk, repo, name), auth.identityId)
if (retired) await defineLabel(sdk, auth, repo, { name, retired: true, ...(intent ? { intent: `${intent}:retire` } : {}) })
for (const d of mine) {
await deleteDocumentIdempotent(sdk, auth, { contractId: repo.forge.core, documentType: DOC.label, documentId: d.id, repo: repo.repoId })
diff --git a/forge-web/lib/repo/milestones.ts b/forge-web/lib/repo/milestones.ts
index 9a6466eb6..b988192c5 100644
--- a/forge-web/lib/repo/milestones.ts
+++ b/forge-web/lib/repo/milestones.ts
@@ -7,43 +7,54 @@
import type { EvoSDK } from '@dashevo/evo-sdk'
import { foldMilestonesV2, type Milestone, type MilestoneDoc, type MilestoneItem } from '../rules/parity'
-import { deleteDocumentIdempotent, queryAllDocuments, type PlainDocument, type WriteAuth, type WriteResult } from '../sdk'
+import { deleteDocumentIdempotent, queryAllDocuments, type WriteAuth, type WriteResult } from '../sdk'
import { utf8Length } from '../view/issue-query'
import { DOC, num, str, type RepoRef } from './contract'
import { repoSource } from './source'
import { contractFor, writeRepoDoc } from './writes'
-/** Every `milestone` document of `repo` (all definitions, oldest first per title). */
-function readMilestoneDocs(sdk: EvoSDK, repo: RepoRef): Promise {
- return queryAllDocuments(sdk, repoSource(repo).repoQuery(DOC.milestone, { orderBy: [['repoId', 'asc'], ['title', 'asc'], ['$createdAt', 'asc']] }))
+/** A milestone definition document's id and signer (a definition is deletable by its owner only). */
+export interface MilestoneDocRef {
+ readonly id: string
+ readonly owner: string
}
-function milestoneDocOf(d: PlainDocument): MilestoneDoc {
- return {
- id: str(d, '$id'),
- title: str(d, 'title'),
- description: str(d, 'description'),
- dueOn: typeof d['dueOn'] === 'number' ? d['dueOn'] : null,
- closed: d['closed'] === true,
- createdAt: num(d, '$createdAt'),
+/** Every `milestone` definition of a repo, read once: the documents to fold, and each title's documents by signer. */
+export interface MilestoneDefs {
+ readonly docs: readonly MilestoneDoc[]
+ readonly owners: ReadonlyMap
+}
+
+/** Every `milestone` document of `repo` (all definitions, oldest first per title), in one read. */
+export async function readMilestoneDefs(sdk: EvoSDK, repo: RepoRef): Promise {
+ const raw = await queryAllDocuments(sdk, repoSource(repo).repoQuery(DOC.milestone, { orderBy: [['repoId', 'asc'], ['title', 'asc'], ['$createdAt', 'asc']] }))
+ const docs: MilestoneDoc[] = []
+ const owners = new Map()
+ for (const d of raw) {
+ const doc: MilestoneDoc = {
+ id: str(d, '$id'),
+ title: str(d, 'title'),
+ description: str(d, 'description'),
+ dueOn: typeof d['dueOn'] === 'number' ? d['dueOn'] : null,
+ closed: d['closed'] === true,
+ createdAt: num(d, '$createdAt'),
+ }
+ docs.push(doc)
+ const list = owners.get(doc.title) ?? []
+ list.push({ id: doc.id, owner: str(d, '$ownerId') })
+ owners.set(doc.title, list)
}
+ return { docs, owners }
}
/** A repo's milestones with their progress over `items` (each issue's open state and milestone). */
export async function readMilestones(sdk: EvoSDK, repo: RepoRef, items: readonly MilestoneItem[] = []): Promise {
- return foldMilestonesV2((await readMilestoneDocs(sdk, repo)).map(milestoneDocOf), items)
+ return foldMilestonesV2((await readMilestoneDefs(sdk, repo)).docs, items)
}
-/** A milestone's definition documents' ids and signers, by title (a definition is deletable by its owner only). */
-export async function readMilestoneOwners(sdk: EvoSDK, repo: RepoRef): Promise