Skip to content

Unsafe GetInt, GetBool, GetFloat, and GetDouble leading to potential buffer overruns #644

Description

@adriengivry

Description

The current implementation of our GetInt, GetBool, GetFloat, and GetDouble functions is unsafe.

This has been partially addressed by #640 which proposed a workaround for the GetInt which is currently being used, and therefore required immediate attention.

This issue has been addressed on baregl (modern OpenGL wrapper) by this PR: adriengivry/baregl#10

Expected Solution

We need to provide a way to specify the buffer size, while providing ways to retrieve single values, arrays, and add support for indexed get parameters.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CriticalSomething that should be fixed quicklyGraphicsGraphical feature

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions