feat: Replace run_checks.sh with prek pre-commit hooks (#516)

* feat: Replace run_checks.sh with prek pre-commit hooks

- Add prek as dev dependency for faster, Rust-based pre-commit hooks
- Add .pre-commit-config.yaml with ruff, pyright, uv.lock check, and pytest hooks
- Rename ruff.yml workflow to prek.yml, now runs all hooks via prek
- pytest runs as manual hook locally but included in CI
- Delete run_checks.sh (superseded by prek hooks)
- Update CONTRIBUTING.md and AGENT.md with new workflow

* ci: Trigger prek workflow on PRs to any branch

This enables CI checks for stacked PRs that target non-main branches.

---------

Co-authored-by: Cursor Bot <bot@cursor.com>

Author: corbt

.github/workflows/ruff.yml .github/workflows/prek.yml.github/workflows/ruff.yml renamed to .github/workflows/prek.yml

@@ -1,8 +1,7 @@
-name: Code Quality Checks
+name: Prek
 
 on:
   pull_request:
-    branches: [ main ]
   push:
     branches: [ main ]
 
@@ -28,17 +27,10 @@ jobs:
       run: |
         uv sync --all-extras
     
-    - name: Run code quality checks
+    - name: Run prek hooks (lint, format, typecheck, uv.lock, tests)
+      run: |
+        uv run prek run --all-files
+
+    - name: Run unit tests (via prek)
       run: |
-        ./scripts/run_checks.sh --verbose-test-failure || {
-          echo ""
-          echo "❌ Code quality checks failed!"
-          echo ""
-          echo "To fix these issues locally, run:"
-          echo "  ./scripts/run_checks.sh --fix"
-          echo ""
-          echo "Then commit and push the changes."
-          echo ""
-          echo "For more details, see CONTRIBUTING.md"
-          exit 1
-        }
+        uv run prek run pytest

.pre-commit-config.yaml

@@ -0,0 +1,27 @@
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.12.1
+    hooks:
+      - id: ruff
+      - id: ruff-format
+
+  - repo: local
+    hooks:
+      - id: pyright
+        name: Pyright type checking
+        entry: uv run pyright src tests
+        language: system
+        pass_filenames: false
+
+      - id: uv-lock-check
+        name: uv.lock sync check
+        entry: uv lock --check
+        language: system
+        pass_filenames: false
+
+      - id: pytest
+        name: Unit tests (manual)
+        entry: uv run pytest --nbval --current-env --tb=short tests/unit
+        language: system
+        pass_filenames: false
+        stages: [manual]

AGENT.md

@@ -8,7 +8,7 @@ This project uses the `uv` package manager.
 
 ## Testing
 
-- Always run tests before committing. The test command is `./scripts/run_checks.sh`.
+- Always run tests before committing. The test command is `uv run prek run --all-files`.
 
 ## Releases
 

CONTRIBUTING.md

@@ -10,28 +10,32 @@ cd ART
 Install the dependencies:
 
 ```bash
-uv sync
+uv sync --group dev
 ```
 
-### Code Formatting and Linting
+### Code Quality Checks (prek)
 
-This project uses [ruff](https://github.com/astral-sh/ruff) for both code formatting and linting. Before submitting a pull request, please ensure your code passes all quality checks:
+This project uses [prek](https://github.com/j178/prek) to run local checks (ruff, pyright, uv.lock sync, and unit tests). Before submitting a pull request, please ensure your code passes all quality checks:
 
 ```bash
-# Run all code quality checks (formatting, linting, and dependency sync)
-./scripts/run_checks.sh
+# Install git hooks (optional but recommended)
+uv run prek install
 
-# Automatically fix any issues that can be fixed
-./scripts/run_checks.sh --fix
+# Run all checks against all files (formatting, linting, typecheck, uv.lock, tests)
+uv run prek run --all-files
 ```
 
-The `run_checks.sh` script will:
+You can also run individual hooks:
 
-1. Check code formatting with ruff
-2. Check for linting issues with ruff
-3. Verify that `uv.lock` is in sync with `pyproject.toml`
+```bash
+uv run prek run ruff
+uv run prek run ruff-format
+uv run prek run pyright
+uv run prek run uv-lock-check
+uv run prek run pytest
+```
 
-These checks are automatically run in CI for all pull requests. If your PR fails these checks, simply run `./scripts/run_checks.sh --fix` locally and commit the changes.
+These checks are automatically run in CI for all pull requests. If your PR fails these checks, re-run the corresponding `prek` hook locally and commit any fixes.
 
 ### Release Process
 

pyproject.toml

@@ -117,6 +117,7 @@ dev = [
     "pytest-asyncio>=1.1.0",
     "duckdb>=1.0.0",
     "pyarrow>=15.0.0",
+    "prek>=0.2.29",
 ]
 
 [tool.uv.sources]