From 57f14d109f21ab9cbeb6fd487ff86846998c0fb6 Mon Sep 17 00:00:00 2001 From: ymote <151983+ymote@users.noreply.github.com> Date: Wed, 7 Oct 2026 19:04:14 -0700 Subject: [PATCH] shell: the two #357 tests build only with app-hub, like their helpers card_runner_restyle_keeps_dynamic_labels_wrapped_and_explicit_no_wrap uses octosense_appstore (an app-hub optional dependency) and selected_glance_style_reaches_existing_cards_without_replacing_state calls tile_cx, which is cfg(feature = "app-hub") -- so a no-default-features lib test build of octosense-shell (the --linux-host sandbox:: check) has not compiled since #357. Both tests now carry the gate their helpers already have; with --features mobile-apps they run and pass as before. Co-Authored-By: Claude Fable 5 --- crates/shell/src/glance_card.rs | 1 + crates/shell/src/module_resize_tests.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/crates/shell/src/glance_card.rs b/crates/shell/src/glance_card.rs index 16d8c7ef..2d1fcbe8 100644 --- a/crates/shell/src/glance_card.rs +++ b/crates/shell/src/glance_card.rs @@ -1469,6 +1469,7 @@ mod tests { } #[test] + #[cfg(feature = "app-hub")] fn selected_glance_style_reaches_existing_cards_without_replacing_state() { use makepad_widgets::makepad_draw::cx_draw::CxDraw; let mut cx = tile_cx(); diff --git a/crates/shell/src/module_resize_tests.rs b/crates/shell/src/module_resize_tests.rs index 2b60a067..e8a9f663 100644 --- a/crates/shell/src/module_resize_tests.rs +++ b/crates/shell/src/module_resize_tests.rs @@ -515,6 +515,7 @@ fn card_runner_restyles_nested_script_without_replacing_draft() { } #[test] +#[cfg(feature = "app-hub")] fn card_runner_restyle_keeps_dynamic_labels_wrapped_and_explicit_no_wrap() { use makepad_app_module::AppModule; let mut cx = Cx::new(Box::new(|_, _| {}));