Duplicate sch:pattern ids prevent Schematron compilation for both independent schemas

[dragosprisaca]

Describe the bug

independent-definitions-schema.xsd and independent-system-characteristics-schema.xsd each declare a sch:pattern id more than once. ISO Schematron types @id as xsd:ID, so the assembled schema fails RELAX NG validation and the Schematron cannot be compiled at all. No rule in either schema can be evaluated, including the reference and deprecation rules that do exist and are correct.

ind-def_txt54objpattern appears three times, on shellcommand_object, shellcommand_state, and textfilecontent54_object. The first two were copied from the textfilecontent54 pattern when shellcommand was added and kept its id.

ind-sc_sql_item_dep appears twice, on sql_item and sql57_item.

Both ids were unique in 5.11.2; the duplicates arrived with the new shellcommand test and the sql57_item.

Replication Steps

1. Extract the Schematron with tools/ExtractSchFromXSD.xsl from independent-definitions-schema.xsd.
2. Compile it, for example lxml.isoschematron.Schematron(extracted).
3. Compilation fails:

invalid schematron schema: <string>:1122:0:ERROR:RELAXNGV:
RELAXNG_ERR_INVALIDATTR: Invalid attribute id for element pattern

The same happens at line 465 of independent-system-characteristics-schema.xsd.

Expected behavior

Every sch:pattern/@id is unique within a schema and within its import closure, so the Schematron compiles and its rules run.

Content

Schema	Duplicate id	Element	Suggested id
independent-definitions	ind-def_txt54objpattern	shellcommand_object	ind-def_shellcommandobjpattern
independent-definitions	ind-def_txt54objpattern	shellcommand_state	ind-def_shellcommandstatepattern
independent-definitions	ind-def_txt54objpattern	textfilecontent54_object	keep as is
independent-system-characteristics	ind-sc_sql_item_dep	sql_item	keep as is
independent-system-characteristics	ind-sc_sql_item_dep	sql57_item	ind-sc_sql57_item_dep

OVAL details

• Schema: independent-definitions-schema.xsd, independent-system-characteristics-schema.xsd
• Test: shellcommand, textfilecontent54, sql, sql57

[dragosprisaca]

One correction beyond the duplicate ids, found while fixing them.

Both shellcommand rules were copied verbatim from textfilecontent54 and kept the source id, context and assertion, so all three were wrong for the element they annotate:

Element	Released rule	Should be
shellcommand_object/pattern	context ind-def:textfilecontent54_object/ind-def:pattern	ind-def:shellcommand_object/ind-def:pattern
shellcommand_state/pattern	context ind-def:textfilecontent54_state/ind-def:pattern, asserting @operation='pattern match'	ind-def:shellcommand_state/ind-def:pattern, asserting not(@operation) or @operation='equals'

The assertion change matters. That entity's own documentation reads:

The 'pattern' is a regular expression that identifies lines in 'command' results that are to produce OVAL items and must match the same element in the associated shellcommand_object, verbatim.

"verbatim" means string equality against the object's pattern, so requiring operation='pattern match' on the state was wrong. The object keeps pattern match, since its pattern is the regular expression actually being applied.

Also in scope: the sql57_item deprecation pattern carried the ind-sc_sql_item_dep id and had context ind-sc:sql_item, so sql57_item was never reported and sql_item was reported twice.